42crunch url #85
Merged
42crunch url #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jasmingacic <jasmin.gacic@gmail.com>
Signed-off-by: jasmingacic <jasmin.gacic@gmail.com>
aabedraba
reviewed
Dec 7, 2022
Co-authored-by: Abdallah Abedraba <aabedraba@gmail.com>
mbana
suggested changes
Dec 7, 2022
Signed-off-by: jasmingacic <jasmin.gacic@gmail.com>
mbana
previously approved these changes
Dec 7, 2022
4 tasks
mbana
added a commit
to kubeshop/kusk-gateway
that referenced
this pull request
Dec 12, 2022
Summary ======= Merge changes from kubeshop/kuskgateway-api-server#85 that were missed in the migration of `kuskgateway-api-server` to `kusk-gateway`. `Makefile-kusk-gateway-api` --------------------------- Add targets to build images that were lost in the merge. Invoke as `make -f Makefile-kusk-gateway-api all`. --- Signed-off-by: Mohamed Bana <mohamed@bana.io>
mbana
added a commit
to kubeshop/kusk-gateway
that referenced
this pull request
Dec 12, 2022
Summary ======= Merge changes from kubeshop/kuskgateway-api-server#85 that were missed in the migration of `kuskgateway-api-server` to `kusk-gateway`. `Makefile-kusk-gateway-api` --------------------------- Add targets to build images that were lost in the merge. Invoke as `make -f Makefile-kusk-gateway-api all`. --- Signed-off-by: Mohamed Bana <mohamed@bana.io>
mbana
added a commit
to kubeshop/kusk-gateway
that referenced
this pull request
Dec 12, 2022
Summary ======= Merge changes from kubeshop/kuskgateway-api-server#85 that were missed in the migration of `kuskgateway-api-server` to `kusk-gateway`. `Makefile-kusk-gateway-api` --------------------------- Add targets to build images that were lost in the merge. Invoke as `make -f Makefile-kusk-gateway-api all`. --- Signed-off-by: Mohamed Bana <mohamed@bana.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR returns Crunch42URL in the APIItem.
In order to achieve that I added KGW dependency from the main branch hence
github.com/kubeshop/kusk-gateway v1.5.1-0.20221207083051-c3507a110867Also you will notice I didn't handle any errors for 42Crunch as we don't want to break if we can't get the URL
Unblocks kubeshop/kusk-gateway#974
Signed-off-by: jasmingacic jasmin.gacic@gmail.com