Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambassador2 removed AmbassadorMapping in exchange for Mapping as of V… #184

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

mg185363
Copy link
Contributor

@mg185363 mg185363 commented Nov 2, 2021

…ersion 2.0.4

This PR...

Changes

In Ambassador Version Version 2.0.4 (October 19, 2021), the prefix "Ambassador" was removed.
Updates

Fixes

Removed the prefix "Ambassador" from Mapping Kind

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@dobegor dobegor self-requested a review November 2, 2021 19:32
@dobegor
Copy link
Contributor

dobegor commented Nov 2, 2021

@mg185363 thank you for your contribution to kusk!

I'll review your pull request and get back to you ASAP.

@dobegor
Copy link
Contributor

dobegor commented Nov 3, 2021

@mg185363 I've just tried Ambassador 2.0.4 and
error: unable to recognize "quote-backend.yaml": no matches for kind "Mapping" in version "x.getambassador.io/v3alpha1"
It seems that we'd also need to change the API "x.getambassador.io/v3alpha1" to "getambassador.io/v3alpha1".

They also state that:

Note that getambassador.io/v3alpha1 is the only supported API version for 2.0.4

@dobegor dobegor merged commit 22259d1 into kubeshop:main Nov 3, 2021
@dobegor
Copy link
Contributor

dobegor commented Nov 4, 2021

@mg185363 hi! your PR is available as of kusk 0.5.0 release.

do you mind telling us about your use case with kusk? we'd be super happy to hear some feedback to continue improving our products!

we can do it on Discord if that's OK for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants