Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow PathType for ingress to be defined other than Prefix #709

Closed
fulgas opened this issue Jan 17, 2024 · 1 comment · Fixed by #710
Closed

Allow PathType for ingress to be defined other than Prefix #709

fulgas opened this issue Jan 17, 2024 · 1 comment · Fixed by #710

Comments

@fulgas
Copy link
Contributor

fulgas commented Jan 17, 2024

From Kubernetes 1.22, i think, the the PathType on the Ingress needs to be ImplementationSpecific when using regex.

https://kubernetes.github.io/ingress-nginx/faq/#validation-of-path

When "ingress.spec.rules.http.pathType=Exact" or "pathType=Prefix", this validation will limit the characters accepted on the field "ingress.spec.rules.http.paths.path", to "alphanumeric characters", and "/," "_," "-." Also, in this case, the path should start with "/."

When the ingress resource path contains other characters (like on rewrite configurations), the pathType value should be "ImplementationSpecific".
@vsukhin
Copy link
Contributor

vsukhin commented Jan 17, 2024

thank you @fulgas for @ypoplavs to check it out

fulgas pushed a commit to fulgas/testkube-helm-charts that referenced this issue Jan 17, 2024
fix: allow setting pathtype for testkube api and dashboard ingress
bd0dce9 
closes kubeshop#709
@fulgas fulgas mentioned this issue Jan 17, 2024
Merged
6 tasks
fulgas added a commit to fulgas/testkube-helm-charts that referenced this issue Jan 17, 2024
@fulgas
fix: allow setting pathtype for testkube api and dashboard ingress
6117d90 
closes kubeshop#709
fulgas added a commit to fulgas/testkube-helm-charts that referenced this issue Jan 17, 2024
@fulgas
fix: allow setting pathtype for testkube api and dashboard ingress
95ab4e2 
closes kubeshop#709
fulgas added a commit to fulgas/testkube-helm-charts that referenced this issue Jan 24, 2024
@fulgas
fix: set prefix as a string rather than a function
c4c5c9a 
closes kubeshop#709
ypoplavs pushed a commit that referenced this issue Jan 24, 2024
@fulgas @ypoplavs
fix: allow setting pathtype for testkube api and dashboard ingress
b5a4931 
closes #709
ypoplavs pushed a commit that referenced this issue Jan 24, 2024
@fulgas @ypoplavs
fix: set prefix as a string rather than a function
cbf1b83 
closes #709
vsukhin added a commit that referenced this issue Jan 25, 2024
@vsukhin @ypoplavs
@dejanzele @vLia @exu @nicufk @igaskin @maxforasteiro @emamihe @fulgas
Release/v1.16.25 (#716)
a836ffe 
* Update executors.json

* fix sync fpr hpa (#672)

* feat: use argo cd sync var

* Update executors.json

* Update values-develop.yaml

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update Chart.yaml files

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update Chart.yaml files

* Update Chart.yaml files

* Update Chart.yaml file

* Update executors.json

* Update executors.json

* testkube: add support for finer-grained MinIO TLS configuration (#677)

* testkube: add finer support for minio tls

* testkube: add changes in testkube-api deployment

* testkube-api: update templates so they render correctly in ConfigMap (#678)

* testkube-api: update templates so they render correctly in ConfigMap

* testkube-api: fix providing some config values directly

* Update Chart.yaml files

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* feat: slave pod spec (#674)

* feat: slave pod spec

* feat: add template enum

* feat: slave pod template

* fix: pod loop

* fix: rename containers

* fix: remove spaces

* fix: rename file

* fix: remove tab

* fix: template indent

* testkube: add support for running NATS with TLS; add support for TLS … (#679)

* testkube: add support for running NATS with TLS; add support for TLS in nats and minio client using self-signed certificates

* testkube: update docs on TLS setup for NATS and MinIO

* Update executors.json

* testkube: update docs on TLS setup for skipping certificate verification

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* Update Chart.yaml files

* Update Chart.yaml files

* Update Chart.yaml file

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update Chart.yaml files

* Update executors.json

* Update Chart.yaml files

* Update Chart.yaml file

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* Revert "feat: add nats endpoint to operator (#661)" (#685)

This reverts commit 613e3d8.

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* Update executors.json

* Update executors.json

* fix: step start and end time

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* feat: shared artifacts

* fix: rename pvc template file

* fix: artifact volume for init container

* fix: add previous test names

* fix: typo in template

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* feat: install only specified executors

* fix: add docs

* fix: rename var

* fix: comment change

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml file

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update Chart.yaml file

* feat: add "cloud" ui url (#692)

* testkube: increase storage size for our envs and add expiration date

* update minio storage

* Adding option to testkube-api-server deployment to specify hostNetwork and dnsPolicy (#660)

* fix: Remove tolerations from testkube-operator since proxy image doesn't support arm64 nodes

* testkube: enable jetstream in nats (#666)

* testkube: enable jetstream in nats

* testkube: update README

* Update executors.json

* fix ingress class

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* feat: added logs sidecar container (#704)

* feat: added logs sidecar container

* feat: added logs sidecar container

* fix: default to false logs v2

* fix: removed from global fie

* fix: job template with registry support

* fix: removing nats-box tools

* fix: added logs-sidecar to the executors.json file

* fix: rollback changes for natsbox in prod

* feat: added roles and service account

* fix: disabling nats box for dev and stage

* fix: rollback sa from logs service - will be moved to valid logs service chart

* fix: logs sidecar to build pipeline

* testkube: add support for connecting to agent in insecure mode and skipping cert validation (#690)

* testkube: rebase with latest changes

* testkube: update docs

* testkube: temporarily disable jetstream (#705)

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* fix: pvc name

* Update executors.json

* Update executors.json

* fix: scraper logs not behind feature flag (#708)

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* added the chart for testkube-logs

* some changes in values files

* helm chart improvement

* modified test

* fix: added logs chart to main testkube chart

* fix: added helm charts for logs-service

* fix: name override

* enable logs service

* disable logs service

* Update executors.json

* Update executors.json

* fix: container executor logs sidecar fix  (#713)

* added the chart for testkube-logs

* some changes in values files

* helm chart improvement

* modified test

* fix: added logs chart to main testkube chart

* fix: added helm charts for logs-service

* fix: name override

* fix: container executor image when no registry registry

---------

Co-authored-by: Hamid Emamian <emami.he@gmail.com>

* Update executors.json

* Update executors.json

* Update executors.json

* fix: allow setting pathtype for testkube api and dashboard ingress

closes #709

* fix: set prefix as a string rather than a function

closes #709

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

---------

Co-authored-by: kubeshop-bot <kubeshop-bot@kubeshop.io>
Co-authored-by: ypoplavs <45286051+ypoplavs@users.noreply.github.com>
Co-authored-by: vsukhin <vsukhin@users.noreply.github.com>
Co-authored-by: Dejan Zele Pejchev <pejcev.dejan@gmail.com>
Co-authored-by: dejanzele <dejanzele@users.noreply.github.com>
Co-authored-by: Lilla Vass <vLia@users.noreply.github.com>
Co-authored-by: exu <exu@users.noreply.github.com>
Co-authored-by: nicufk <nicolae@kubeshop.io>
Co-authored-by: ypoplavs <yulia.poplavska@kubeshop.io>
Co-authored-by: Isaac Gaskin <isaac.gaskin@circle.com>
Co-authored-by: Max Forasteiro <18661016+maxforasteiro@users.noreply.github.com>
Co-authored-by: Jacek Wysocki <jacek.wysocki@gmail.com>
Co-authored-by: Hamid Emamian <emami.he@gmail.com>
Co-authored-by: Nelson Silva <nelson.emanuel.silva@gmail.com>
vsukhin added a commit that referenced this issue Feb 5, 2024
@vsukhin @dejanzele
@vLia @exu @nicufk @ypoplavs @igaskin @maxforasteiro @emamihe @fulgas
feat: Release/v1.16.26 (#725)
acb8421 
* Update Chart.yaml files

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update Chart.yaml files

* Update Chart.yaml files

* Update Chart.yaml file

* Update executors.json

* Update executors.json

* testkube: add support for finer-grained MinIO TLS configuration (#677)

* testkube: add finer support for minio tls

* testkube: add changes in testkube-api deployment

* testkube-api: update templates so they render correctly in ConfigMap (#678)

* testkube-api: update templates so they render correctly in ConfigMap

* testkube-api: fix providing some config values directly

* Update Chart.yaml files

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* feat: slave pod spec (#674)

* feat: slave pod spec

* feat: add template enum

* feat: slave pod template

* fix: pod loop

* fix: rename containers

* fix: remove spaces

* fix: rename file

* fix: remove tab

* fix: template indent

* testkube: add support for running NATS with TLS; add support for TLS … (#679)

* testkube: add support for running NATS with TLS; add support for TLS in nats and minio client using self-signed certificates

* testkube: update docs on TLS setup for NATS and MinIO

* Update executors.json

* testkube: update docs on TLS setup for skipping certificate verification

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* Update Chart.yaml files

* Update Chart.yaml files

* Update Chart.yaml file

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update Chart.yaml files

* Update executors.json

* Update Chart.yaml files

* Update Chart.yaml file

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* Revert "feat: add nats endpoint to operator (#661)" (#685)

This reverts commit 613e3d8.

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* Update executors.json

* Update executors.json

* fix: step start and end time

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* feat: shared artifacts

* fix: rename pvc template file

* fix: artifact volume for init container

* fix: add previous test names

* fix: typo in template

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* feat: install only specified executors

* fix: add docs

* fix: rename var

* fix: comment change

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml file

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update Chart.yaml file

* feat: add "cloud" ui url (#692)

* testkube: increase storage size for our envs and add expiration date

* update minio storage

* Adding option to testkube-api-server deployment to specify hostNetwork and dnsPolicy (#660)

* fix: Remove tolerations from testkube-operator since proxy image doesn't support arm64 nodes

* testkube: enable jetstream in nats (#666)

* testkube: enable jetstream in nats

* testkube: update README

* Update executors.json

* fix ingress class

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* feat: added logs sidecar container (#704)

* feat: added logs sidecar container

* feat: added logs sidecar container

* fix: default to false logs v2

* fix: removed from global fie

* fix: job template with registry support

* fix: removing nats-box tools

* fix: added logs-sidecar to the executors.json file

* fix: rollback changes for natsbox in prod

* feat: added roles and service account

* fix: disabling nats box for dev and stage

* fix: rollback sa from logs service - will be moved to valid logs service chart

* fix: logs sidecar to build pipeline

* testkube: add support for connecting to agent in insecure mode and skipping cert validation (#690)

* testkube: rebase with latest changes

* testkube: update docs

* testkube: temporarily disable jetstream (#705)

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update executors.json

* fix: pvc name

* Update executors.json

* Update executors.json

* fix: scraper logs not behind feature flag (#708)

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* added the chart for testkube-logs

* some changes in values files

* helm chart improvement

* modified test

* fix: added logs chart to main testkube chart

* fix: added helm charts for logs-service

* fix: name override

* enable logs service

* disable logs service

* Update executors.json

* Update executors.json

* fix: container executor logs sidecar fix  (#713)

* added the chart for testkube-logs

* some changes in values files

* helm chart improvement

* modified test

* fix: added logs chart to main testkube chart

* fix: added helm charts for logs-service

* fix: name override

* fix: container executor image when no registry registry

---------

Co-authored-by: Hamid Emamian <emami.he@gmail.com>

* Update executors.json

* Update executors.json

* Update executors.json

* fix: allow setting pathtype for testkube api and dashboard ingress

closes #709

* fix: set prefix as a string rather than a function

closes #709

* Update executors.json

* Update executors.json

* Update executors.json

* Update executors.json

* Update Chart.yaml files

* Update Chart.yaml files

* Update Chart.yaml file

* Update executors.json

* Update executors.json

* Update executors.json

* feat: add minio new logs config (#717)

* Update executors.json

* Update Chart.yaml file

* fix: demo globals

* Update executors.json

* fix: log bucket missing (#719)

* Update executors.json

* nats upgarde

* minor fixes

* NATS upgrade

* fix pre-upgarde nats

* Update executors.json

* Update executors.json

* fix: reorder jmeter args

* Update executors.json

* Update executors.json

* fix: logs sideca executor record

---------

Co-authored-by: kubeshop-bot <kubeshop-bot@kubeshop.io>
Co-authored-by: vsukhin <vsukhin@users.noreply.github.com>
Co-authored-by: Dejan Zele Pejchev <pejcev.dejan@gmail.com>
Co-authored-by: dejanzele <dejanzele@users.noreply.github.com>
Co-authored-by: Lilla Vass <vLia@users.noreply.github.com>
Co-authored-by: exu <exu@users.noreply.github.com>
Co-authored-by: nicufk <nicolae@kubeshop.io>
Co-authored-by: ypoplavs <yulia.poplavska@kubeshop.io>
Co-authored-by: Isaac Gaskin <isaac.gaskin@circle.com>
Co-authored-by: Max Forasteiro <18661016+maxforasteiro@users.noreply.github.com>
Co-authored-by: Jacek Wysocki <jacek.wysocki@gmail.com>
Co-authored-by: Hamid Emamian <emami.he@gmail.com>
Co-authored-by: Nelson Silva <nelson.emanuel.silva@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow setting pathtype for testkube api and dashboard ingress fulgas/testkube-helm-charts
2 participants
@fulgas @vsukhin