Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overwriting custom RBAC config and Kubernetes plugin JSON schema #1401

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Fix overwriting custom RBAC config and Kubernetes plugin JSON schema #1401

merged 3 commits into from
Feb 27, 2024

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Feb 27, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Fix overwriting custom RBAC config
  • Fix Kubernetes extraButtons schema
  • Remove unused properties

Testing

You can run the updated unit test before and after the fix.

@pkosiec pkosiec added the bug Something isn't working label Feb 27, 2024
@pkosiec pkosiec added this to the v1.9.0 milestone Feb 27, 2024
@pkosiec pkosiec marked this pull request as ready for review February 27, 2024 14:35
@pkosiec pkosiec requested review from PrasadG193 and a team as code owners February 27, 2024 14:35
@pkosiec pkosiec changed the title Fix overwriting custom RBAC config and remove unused properties Fix overwriting custom RBAC config and Kubernetes plugin JSON schema Feb 27, 2024
madebyrogal
madebyrogal approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@madebyrogal madebyrogal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkosiec pkosiec merged commit ced876d into kubeshop:main Feb 27, 2024
17 of 18 checks passed
@pkosiec pkosiec deleted the remove-unused-values branch February 27, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madebyrogal madebyrogal madebyrogal approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Botkube
Status: Done
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pkosiec @madebyrogal