Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for old k8s versions by not throwing an error when con… #436

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Adding support for old k8s versions by not throwing an error when con… #436

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58fb5d9
Adding support for old k8s versions by not throwing an error when con…
amitschendel Dec 16, 2024
5a40f2a
Removing comment
amitschendel Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/utils/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,9 +702,10 @@ func DetectContainerRuntimeViaK8sAPI(ctx context.Context, k8sClient *k8sinterfac
// override the socket path
realSocketPath, err := getContainerRuntimeSocketPath(k8sClient, nodeName)
if err != nil {
return nil, fmt.Errorf("failed to get container runtime socket path from Kubelet configz: %v", err)
logger.L().Warning("failed to get container runtime socket path from Kubelet configz", helpers.String("error", err.Error()))
} else {
runtimeConfig.SocketPath = realSocketPath
}
runtimeConfig.SocketPath = realSocketPath
// unset the runtime protocol
runtimeConfig.RuntimeProtocol = ""
return runtimeConfig, nil
Expand Down
Loading