-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding pod-template-hash label #167
Conversation
Signed-off-by: David Wertenteil <dwertent@armosec.io>
PR Description updated to latest commit (c98e5d0) |
PR Analysis
PR Feedback💡 General suggestions: The PR seems to be well implemented with clear and concise changes. However, it would be beneficial to include tests that verify the new functionality. This would ensure that the 🤖 Code feedback:
✨ Usage tips:
|
Summary:
|
Signed-off-by: David Wertenteil <dwertent@armosec.io>
Summary:
|
* support syft types Signed-off-by: DanielGrunbergerCA <grunbagrunba@gmail.com> * fix func call Signed-off-by: DanielGrunbergerCA <grunbagrunba@gmail.com> * init map Signed-off-by: DanielGrunbergerCA <grunbagrunba@gmail.com> * update go: Signed-off-by: DanielGrunbergerCA <grunbagrunba@gmail.com> * update go mod Signed-off-by: David Wertenteil <dwertent@armosec.io> * skip exec events with empty path Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com> * ignore ebpf events with empty container name Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com> * avoid race condition between container start and activity reporting Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com> * remove secrets from obj Signed-off-by: David Wertenteil <dwertent@armosec.io> * Add TemplateHash label (#165) * Add TemplateHash label Signed-off-by: David Wertenteil <dwertent@armosec.io> * fixed test Signed-off-by: David Wertenteil <dwertent@armosec.io> --------- Signed-off-by: David Wertenteil <dwertent@armosec.io> * Bump k8s-interface to 155 (#166) * bump k8s-interface to 155 Signed-off-by: David Wertenteil <dwertent@armosec.io> * fixed name Signed-off-by: David Wertenteil <dwertent@armosec.io> --------- Signed-off-by: David Wertenteil <dwertent@armosec.io> * Adding pod-template-hash label (#167) * Adding pod-template-hash label Signed-off-by: David Wertenteil <dwertent@armosec.io> * bump k8-interface pkg Signed-off-by: David Wertenteil <dwertent@armosec.io> --------- Signed-off-by: David Wertenteil <dwertent@armosec.io> * Call InstanceIDToSlug instead of GetSlug Signed-off-by: David Wertenteil <dwertent@armosec.io> * support syft types Signed-off-by: DanielGrunbergerCA <grunbagrunba@gmail.com> * fix func call Signed-off-by: DanielGrunbergerCA <grunbagrunba@gmail.com> * init map Signed-off-by: DanielGrunbergerCA <grunbagrunba@gmail.com> * update go: Signed-off-by: DanielGrunbergerCA <grunbagrunba@gmail.com> * update go mod Signed-off-by: David Wertenteil <dwertent@armosec.io> * remove secrets from obj Signed-off-by: David Wertenteil <dwertent@armosec.io> --------- Signed-off-by: DanielGrunbergerCA <grunbagrunba@gmail.com> Signed-off-by: David Wertenteil <dwertent@armosec.io> Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com> Co-authored-by: DanielGrunbergerCA <grunbagrunba@gmail.com> Co-authored-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Type
enhancement
Description
This PR introduces the following changes:
pod-template-hash
label is now retrieved from the pod in thegetContainerInfo
function.podTemplateHash
attribute is added to thewatchedContainer
object in theensureImageInfo
function.getContainerInfo
function have been updated to include thepodTemplateHash
attribute.PR changes walkthrough
1 files
relevancy_manager.go
pkg/relevancymanager/v1/relevancy_manager.go
The changes in this file involve adding a new attribute
podTemplateHash
to thegetContainerInfo
function. Thisfunction now retrieves the
pod-template-hash
label fromthe pod and returns it along with other container
information. The
podTemplateHash
is also added to thewatchedContainer
object in theensureImageInfo
function.Error messages in the function have been updated to include
this new attribute.
User description
Overview