Fix EKS error "failed to get cloud data" #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he current context name is the cluster name;
This enhancement resolves the error:
`failed to get cloud data. resourceKind: ClusterDescribe; error: operation error EKS: DescribeCluster, serialization failed: serialization failed: input member name must not be empty`
If cluster name is not an ARN or equal to the context name,
EKSSupport.GetContextName will return an empty string and log
serialization failed.
Signed-off-by: comrumino <comrumino@archstrike.org>
…spect to non-ARN context names; added SetConnectedToCluster to tearDown to make test results more predictable. Signed-off-by: comrumino <comrumino@archstrike.org>
…cloud data. resourceKind: ClusterDescribe; error: not found, ResolveEndpointV2`. This error is a known issue regarding incompatible service module versions. Refer to aws/aws-sdk-go-v2#2370 (comment) for more details. Signed-off-by: comrumino <comrumino@archstrike.org>
comrumino
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106; see my commit messages for a more detailed description of the changes made and links to known module version issues.
Testing GetContextName
I added test coverage for
EKSSupport.GetContextNameto validate the change I made.If you would like to manually reproduce the issue, change
.kube/configfor a valid connection such that the context key-value for cluster is not an ARN. See below for an example config to reproduce the issue.