Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs with topology aware dynamic provisioning #9939

Merged
merged 5 commits into from
Sep 11, 2018
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions content/en/docs/concepts/storage/storage-classes.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,15 +133,14 @@ provisioning](/docs/concepts/storage/persistent-volumes/#provisioning) should oc

By default, the `Immediate` mode indicates that volume binding and dynamic
provisioning occurs once the PVC is created. For storage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we indicate here that PVC == PersistentVolumeClaim?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't hurt to be explicit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PVC and PersistentVolumeClaim were introduced at the beginning of this page

backends that are topology-constrained and not globally accessible from all nodes
in the cluster (for example, a zonal disk, or a local volume), this causes
volumes to be bound or provisioned without knowledge of the pod's scheduling
requirements, and can result in unschedulable pods.

To address this issue, the `WaitForFirstConsumer` mode can be specified which
will delay binding and provisioning until a pod using the PVC is created.
Volumes will be selected or provisioned with the appropriate topology that is
compatible with the pod's scheduling constraints, including but not limited to, [resource
backends that are topology-constrained and not globally accessible from all Nodes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it be possible to keep the examples of common topology-constrained volume types [a zonal disk like EBS/GCE PD/Azure Managed disk or a local volume] as was specified earlier? It helps the reader understands where WaitForFirstConsumer is specifically applicable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list of supported plugins is below. Is that what you meant?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, that should be good.

in the cluster, Volumes will be bound or provisioned without knowledge of the Pod's scheduling
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Volumes => PVs

requirements. This may result in unschedulable Pods.

A cluster administrator can address this issue by specifying the `WaitForFirstConsumer` mode which
will delay the binding and provisioning of a Volume until a Pod using the PVC is created.
Volumes will be selected or provisioned conforming to the topology that is
specified by the Pod's scheduling constraints. These include, but are not limited to, [resource
requirements](/docs/concepts/configuration/manage-compute-resources-container),
[node selectors](/docs/concepts/configuration/assign-pod-node/#nodeselector),
[pod affinity and
Expand All @@ -165,11 +164,11 @@ The following plugins support `WaitForFirstConsumer` with pre-created PV binding
**Note:** This feature requires the `VolumeScheduling` feature gate to be
enabled.

When `WaitForFirstConsumer` volume binding mode is specified, it is no longer necessary
When a cluster operactor specifies the `WaitForFirstConsumer` volume binding mode, it is no longer necessary
to restrict provisioning to specific topologies in most situations. However,
if still required, `allowedTopologies` can be specified.

This example demonstrates how to restrict topology of provisioned volumes to specific
This example demonstrates how to restrict the topology of provisioned volumes to specific
zones and should be used as a replacement for the `zone` and `zones` parameters for the
supported plugins.

Expand Down