Kubeadm kubelet integration doc #9652

neolit123 · 2018-07-26T20:04:42Z

Part of kubernetes/kubeadm#849
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews

orginal PR:
#9123

since i cannot push to @luxas branch here are my editorial fixes and also i've moved the file to setup/independent.

neolit123 · 2018-07-26T20:06:10Z

/assign @Bradamant3

neolit123 · 2018-07-26T20:06:41Z

/assign @neolit123

k8sio-netlify-preview-bot · 2018-07-26T20:08:12Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 52b1f06

https://deploy-preview-9652--kubernetes-io-master-staging.netlify.com

stewart-yu

Have some nil comments

stewart-yu · 2018-07-28T02:35:24Z

content/en/docs/setup/independent/kubelet-integration.md

+
+Let's say that you have a default service subnet defined as `10.96.0.0/12` and you pass this parameter to kubeadm:
+```bash
+kubeadm init --service-cidr 10.95.0.0/12


replace 10.95.0.0/12 to 10.96.0.0/12 ?

stewart-yu · 2018-07-28T02:36:17Z

content/en/docs/setup/independent/kubelet-integration.md

+```
+
+In this example, the modified value is the subnet used for allocating the Service Virtual IPs.
+This means that the `--cluster-dns` kubelet flag also has to be set, to `10.95.0.10` following this example.


stewart-yu · 2018-07-28T02:43:16Z

content/en/docs/setup/independent/kubelet-integration.md

+
+- Different kubelet parameters need to be passed depending on what CRI runtime is used. In the case of docker,
+you need to specify flags like `--network-plugin=cni` for it to work, but if you're using some other, external runtime
+you should set `--container-runtime=remote` and specify the CRI endpoint with `--container-runtime-endpoint=<path>`.


...., but if you're using some external runtime. you should set ....

stewart-yu · 2018-07-28T02:48:23Z

content/en/docs/setup/independent/kubelet-integration.md

+to make the kubelet pick up the latest dynamic flags which were previously written. After that the rest of the regular
+`kubeadm init` workflow continues.
+
+`kubeadm join` on the other hand, uses the Bootstrap Token credential to download the `kubelet-config-1.X` ConfigMap


"on the other hand, kubeadm join .... ", may be seems well

neolit123 · 2018-07-30T12:13:53Z

thanks for the review, @stewart-yu
i've added the edits as a new commit.

stewart-yu

some nil format review, thanks

stewart-yu · 2018-07-31T00:24:11Z

content/en/docs/setup/independent/kubelet-integration.md

+- The file that can contain user specified flag overrides with `KUBELET_EXTRA_ARGS` is sourced from `/etc/default/kubelet`
+(for debs), or `/etc/systconfig/kubelet` (for rpms). Note that `KUBELET_EXTRA_ARGS` is last in the flag chain,
+therefore it has the highest priority.
+


Here some wrong format output, may be add a blank line below Notes make it work.
https://deploy-preview-9652--kubernetes-io-master-staging.netlify.com/docs/setup/independent/kubelet-integration/

stewart-yu · 2018-07-31T00:24:19Z

content/en/docs/setup/independent/kubelet-integration.md

+- `kubelet` - ships the `/usr/bin/kubelet` binary.
+- `kubectl` - ships the `/usr/bin/kubectl` binary.
+- `kubernetes-cni` - ships the official CNI binaries under the `/opt/cni/bin` directory.
+- `cri-tools` - ships the `/usr/bin/crictl` binary from https://github.com/kubernetes-incubator/cri-tools


neolit123 · 2018-07-31T00:37:02Z

@stewart-yu
good catch. the doc wasn't using a template as well.
waiting on the preview again and will verify if the formatting is fine.

Also apply MD formatting fixes.

neolit123 · 2018-07-31T00:48:29Z

@stewart-yu
i've applied some formatting fixes. the document looks much better now.
https://deploy-preview-9652--kubernetes-io-master-staging.netlify.com/docs/setup/independent/kubelet-integration/

stewart-yu · 2018-07-31T00:54:02Z

/lgtm
/cc @tengqm @zacharysarah
for approve

mdlinville · 2018-07-31T22:01:07Z

@neolit123 PTAL at the copyedit commit I just added on top of yours. I changed the structure of the file a bit and reworked the prose. Let me know if I accidentally changed any technical meaning with my changes and I'll iterate. Thanks!

neolit123

@mistyhacks
thanks for the review and edits.
i've added some comments about tech deviations and a couple of typos.

i think the new structure is much better.

neolit123 · 2018-07-31T22:27:02Z

content/en/docs/setup/independent/kubelet-integration.md

-The default kubeadm deb/rpm packages ship a systemd drop-in file for the kubelet populated with
-some CLI flags so that the kubelet is functional.
+Like any daemon process, the state of the kubelet needs to be maintained using a lifecycle management
+process such as an init system or process manager. When the kubelet is installed using DEBs or RPMs,


the original is arguably more technically valid here:
Given the kubelet is a daemon, it needs to be maintained by some kind of a init system or process manager.

neolit123 · 2018-07-31T22:29:03Z

content/en/docs/setup/independent/kubelet-integration.md

-some CLI flags so that the kubelet is functional.
+Like any daemon process, the state of the kubelet needs to be maintained using a lifecycle management
+process such as an init system or process manager. When the kubelet is installed using DEBs or RPMs,
+`systemd` manages the kubelet. You can configure a different process management system to manage the


here and across the edit, systemd is not a command to be quoted, but rather a tool / project name like etcd or kubelet. for example, kubeadm is a tool, but kubeadm init is a command line and should be quoted.

neolit123 · 2018-07-31T22:32:40Z

content/en/docs/setup/independent/kubelet-integration.md

+## Kubelet configuration patterns
+
+The following sections describe patterns to kubelet configuration that are simplified by
+using kubeadm, rather than managing the kubelet configuration for each Pod manually.


a kubelet are per Node, not per Pod.

neolit123 · 2018-07-31T22:33:29Z

content/en/docs/setup/independent/kubelet-integration.md

-`kubeadm init` and/or `kubeadm join` commands. Common scenarios include customizing the Service
-Subnet and using a different CRI runtime.
+If you want your services to use the subnet `10.96.0.0/12` as the default for services, you can pass
+the `--service-cidr` marameter to kubeadm:


typo marameter

neolit123 · 2018-07-31T22:34:59Z

content/en/docs/setup/independent/kubelet-integration.md

+### Providing instance-specific configuration details
+
+Some hosts require specific kubelet configurations, due to differences in hardware, operating system,
+networking, or other host-specific parameters. The following list provices a few examples.


typo provices

neolit123 · 2018-07-31T23:13:57Z

content/en/docs/setup/independent/kubelet-integration.md

-named `kubelet-config-1.X`, where `X` is the minor version of the Kubernetes version initialized. `kubeadm init` also
-generates the `/etc/kubernetes/kubelet.conf` KubeConfig file with credentials (client certificates) so that the kubelet
-can talk to the API server.
+When you call `kubeadm init`, the `.kubeletConfiguration.baseConfig`  structure is marshalled to disk


minor-nit: we might as well remove the extra space before structure here.

neolit123 · 2018-07-31T23:16:01Z

content/en/docs/setup/independent/kubelet-integration.md

+baseline cluster-wide configuration for all kubelets in the cluster. This configuration file
+points to the client certificates that allow the kubelet to communicate with the API server. This
+addresses the need to
+[propogate cluster-level configuration to each kubelet](#propagating-cluster-level-configuration-to-each-kubelet).


this is good self-linking 👍

neolit123 · 2018-07-31T23:20:40Z

content/en/docs/setup/independent/kubelet-integration.md

-On the other hand, `kubeadm join` uses the Bootstrap Token credential to download the `kubelet-config-1.X` ConfigMap
-and write it to `/var/lib/kubelet/config.yaml`.
+After marshalling these two files to disk, kubeadm attempts to run the following two
+commands, if you are using systemd to manage your processes:


through out the doc, "process manager" and "manage a process" is slightly misused in the case of systemd, because it's more of a "service manager".
a process is not exactly the same as a service in any OS context.

i would omit to manage your processes to dodge this ambiguity.

neolit123 · 2018-07-31T23:23:01Z

content/en/docs/setup/independent/kubelet-integration.md

-is stored in `/etc/kubernetes/kubelet.conf`. As of kubeadm v1.11, `kubeadm join` waits for the `/etc/kubernetes/kubelet.conf`
-file to appear on disk, which means that the kubelet has performed the TLS Bootstrap.
+When you run `kubeadm join`, kubeadm uses the Bootstrap Token credential to download the
+`kubelet-config-1.X` ConfigMap and writes it to `/var/lib/kubelet/config.yaml`. The dynamic


and writes it -> and write it ?

kubeadm (uses the Bootstrap Token credential....) and writes it. :) Subject-verb agreement.

neolit123 · 2018-07-31T23:24:37Z

content/en/docs/setup/independent/kubelet-integration.md

-At that point the Bootstrap Token is used by the kubelet to perform the TLS Bootstrap and to get the unique credential which
-is stored in `/etc/kubernetes/kubelet.conf`. As of kubeadm v1.11, `kubeadm join` waits for the `/etc/kubernetes/kubelet.conf`
-file to appear on disk, which means that the kubelet has performed the TLS Bootstrap.
+When you run `kubeadm join`, kubeadm uses the Bootstrap Token credential to download the


the bootstrap token is use to perform a TLS bootstrap which fetches the credential.
the original is more technically accurate.

mdlinville · 2018-08-01T20:47:31Z

@neolit123 Thanks, I've just pushed a new commit to address your comments. PTAL!

neolit123 · 2018-08-01T21:32:55Z

@mistyhacks
added a commit with two typo fixes:
52b1f06

this is good to go.
LMK if you want me to squash the commits?

mdlinville · 2018-08-01T22:24:07Z

/lgtm
/approve

k8s-ci-robot · 2018-08-01T22:24:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mistyhacks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mistyhacks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

luxas and others added 3 commits July 26, 2018 20:45

kubeadm: Add a kubelet-kubeadm integration reference doc

1268d55

kubeadm: edits for the kubelet-kubeadm integration doc

b1bcf5f

kubeadm: move the kubelet-kubeadm integration doc

84536ff

k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 26, 2018

k8s-ci-robot requested review from stewart-yu and xiangpengzhao July 26, 2018 20:04

neolit123 mentioned this pull request Jul 26, 2018

kubeadm: Add a kubelet-kubeadm integration reference doc #9123

Closed

k8s-ci-robot assigned Bradamant3 Jul 26, 2018

This comment has been minimized.

Sign in to view

k8s-ci-robot assigned neolit123 Jul 26, 2018

luxas mentioned this pull request Jul 26, 2018

Create new documentation based on user stories kubernetes/kubeadm#849

Closed

9 tasks

stewart-yu reviewed Jul 28, 2018

View reviewed changes

Apply edits to kubelet-integration.md

548d4b9

stewart-yu reviewed Jul 31, 2018

View reviewed changes

neolit123 force-pushed the kubeadm_kubelet_integration_doc branch from 8d241e1 to 7367f87 Compare July 31, 2018 00:43

Make kubelet-integration.md use a template

75e84d1

Also apply MD formatting fixes.

neolit123 force-pushed the kubeadm_kubelet_integration_doc branch from 7367f87 to 75e84d1 Compare July 31, 2018 00:46

k8s-ci-robot assigned stewart-yu Jul 31, 2018

k8s-ci-robot requested review from tengqm and zacharysarah July 31, 2018 00:54

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2018

Copyedit

696a2f8

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2018

neolit123 commented Jul 31, 2018

View reviewed changes

Address feedback on copyedit

7d34da6

added a couple of typo fixes

52b1f06

k8s-ci-robot assigned mdlinville Aug 1, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2018

k8s-ci-robot merged commit 3098e37 into kubernetes:master Aug 1, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kubeadm kubelet integration doc #9652

Kubeadm kubelet integration doc #9652

neolit123 commented Jul 26, 2018 •

edited

Loading

neolit123 commented Jul 26, 2018 •

edited

Loading

This comment has been minimized.

neolit123 commented Jul 26, 2018

k8sio-netlify-preview-bot commented Jul 26, 2018 •

edited

Loading

stewart-yu left a comment

stewart-yu Jul 28, 2018

stewart-yu Jul 28, 2018

stewart-yu Jul 28, 2018

stewart-yu Jul 28, 2018

neolit123 commented Jul 30, 2018

stewart-yu left a comment

stewart-yu Jul 31, 2018

stewart-yu Jul 31, 2018

neolit123 commented Jul 31, 2018

neolit123 commented Jul 31, 2018 •

edited

Loading

stewart-yu commented Jul 31, 2018

mdlinville commented Jul 31, 2018

neolit123 left a comment

neolit123 Jul 31, 2018

neolit123 Jul 31, 2018

neolit123 Jul 31, 2018

neolit123 Jul 31, 2018

neolit123 Jul 31, 2018

neolit123 Jul 31, 2018

neolit123 Jul 31, 2018

neolit123 Jul 31, 2018

neolit123 Jul 31, 2018

mdlinville Aug 1, 2018

neolit123 Jul 31, 2018

mdlinville commented Aug 1, 2018

neolit123 commented Aug 1, 2018

mdlinville commented Aug 1, 2018

k8s-ci-robot commented Aug 1, 2018

Kubeadm kubelet integration doc #9652

Kubeadm kubelet integration doc #9652

Conversation

neolit123 commented Jul 26, 2018 • edited Loading

neolit123 commented Jul 26, 2018 • edited Loading

This comment has been minimized.

neolit123 commented Jul 26, 2018

k8sio-netlify-preview-bot commented Jul 26, 2018 • edited Loading

stewart-yu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

neolit123 commented Jul 30, 2018

stewart-yu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

neolit123 commented Jul 31, 2018

neolit123 commented Jul 31, 2018 • edited Loading

stewart-yu commented Jul 31, 2018

mdlinville commented Jul 31, 2018

neolit123 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mdlinville commented Aug 1, 2018

neolit123 commented Aug 1, 2018

mdlinville commented Aug 1, 2018

k8s-ci-robot commented Aug 1, 2018

neolit123 commented Jul 26, 2018 •

edited

Loading

neolit123 commented Jul 26, 2018 •

edited

Loading

k8sio-netlify-preview-bot commented Jul 26, 2018 •

edited

Loading

neolit123 commented Jul 31, 2018 •

edited

Loading