-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc Bug: 64Mib is 2^26 and not 2^20 #580
Conversation
Please help fix this
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@krmayankk please sign the CLA |
@johndmulhausen we are almost there. The CLA is being signed on behalf by our company. Once its signed, this would automatically show up here as long as my official email address is attached to this profile and that email address is part of the group, though which the signing happens right ? |
@johndmulhausen |
@johndmulhausen can you please verify , my CCLA was signed by Salesforce |
I signed it! |
@johndmulhausen Can you please update cla label, my CLA is signed and approved by Salesforce |
@krmayankk I am going to try and figure out why your cla for salesforce isn't working. |
Thanks @pwittrock really appreciate it. One thing to note is that earlier this account was not associated with Salesforce account but now it's associated so I think the bot should pick up right ? |
cc @lavalamp @krmayankk Is the email address you used for the commit the email address that is part of the group? You can have multiple email addresses associated with your GH account, but your Git client only has 1 email associated with it. |
@pwittrock i used the online kubernetes.github.io to make the PR. My primary email address on my github profile is my salesforce account. When i made this PR, it was another personal email but i switched it later and just to make sure i made two more PR's later :-) but none of them are picking my email address it seems |
From the command line, On Fri, Jul 15, 2016 at 11:37 PM, krmayankk notifications@github.com
|
@pwittrock @lavalamp thanks guys. i just resubmitted from a fork now. Here is the 4 PR for this doc bug :-). thanks for the help, cla shows yes now |
Merged #864 |
* Describe effective and actual metrics Signed-off-by: Alex Leong <alex@buoyant.io>
Please help fix this