Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc Bug: 64Mib is 2^26 and not 2^20 #580

Closed
wants to merge 1 commit into from

Conversation

krmayankk
Copy link
Contributor

Please help fix this

Please help fix this
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@johndmulhausen
Copy link

@krmayankk please sign the CLA

@krmayankk
Copy link
Contributor Author

@johndmulhausen we are almost there. The CLA is being signed on behalf by our company. Once its signed, this would automatically show up here as long as my official email address is attached to this profile and that email address is part of the group, though which the signing happens right ?

@krmayankk
Copy link
Contributor Author

@johndmulhausen
Can you check, my CLA was signed and approved as a corporation by Salesforce Inc

@krmayankk
Copy link
Contributor Author

@johndmulhausen can you please verify , my CCLA was signed by Salesforce

@krmayankk
Copy link
Contributor Author

I signed it!

@krmayankk
Copy link
Contributor Author

@johndmulhausen Can you please update cla label, my CLA is signed and approved by Salesforce

@pwittrock
Copy link
Member

@krmayankk I am going to try and figure out why your cla for salesforce isn't working.

@pwittrock pwittrock self-assigned this Jul 15, 2016
@krmayankk
Copy link
Contributor Author

Thanks @pwittrock really appreciate it. One thing to note is that earlier this account was not associated with Salesforce account but now it's associated so I think the bot should pick up right ?

@pwittrock pwittrock removed the cla: no label Jul 15, 2016
@pwittrock
Copy link
Member

cc @lavalamp

@krmayankk Is the email address you used for the commit the email address that is part of the group? You can have multiple email addresses associated with your GH account, but your Git client only has 1 email associated with it.

@krmayankk
Copy link
Contributor Author

@pwittrock i used the online kubernetes.github.io to make the PR. My primary email address on my github profile is my salesforce account. When i made this PR, it was another personal email but i switched it later and just to make sure i made two more PR's later :-) but none of them are picking my email address it seems

#768
#806

@lavalamp
Copy link
Member

From the command line, git reset --soft HEAD^ && git add <change files> && git commit will remake a commit and drop in the email set in your git
config. There's probably a better way, but that will get the job done. Not
sure if that'll be possible from the github interface.

On Fri, Jul 15, 2016 at 11:37 PM, krmayankk notifications@github.com
wrote:

@pwittrock https://github.com/pwittrock i used the online
kubernetes.github.io to make the PR. My primary email address on my
github profile is my salesforce account. When i made this PR, it was
another personal email but i switched it later and just to make sure i made
two more PR's later :-) but none of them are picking my email address it
seems

#768 #768
#806 #806


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#580 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAnglkzr8UqgTVag3rVHPyKpo1X_1mvlks5qWHwSgaJpZM4In6gn
.

@krmayankk
Copy link
Contributor Author

@pwittrock @lavalamp thanks guys. i just resubmitted from a fork now. Here is the 4 PR for this doc bug :-). thanks for the help, cla shows yes now

#864

@pwittrock
Copy link
Member

Merged #864

@pwittrock pwittrock closed this Jul 18, 2016
mikutas pushed a commit to mikutas/k8s-website that referenced this pull request Feb 24, 2021
* Describe effective and actual metrics

Signed-off-by: Alex Leong <alex@buoyant.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants