Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4004: Promote DisableNodeKubeProxyVersion feature gate to default enable #49975

Open
wants to merge 1 commit into
base: dev-1.33
Choose a base branch
from
Open

KEP-4004: Promote DisableNodeKubeProxyVersion feature gate to default enable #49975

wants to merge 1 commit into from
+7 −3

Conversation

HirazawaUi
Copy link
Contributor

Description

Promote DisableNodeKubeProxyVersion feature gate to default enable

Issue

Closes: #

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 2, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign reylejano for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 2, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 2, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 5ff0239
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67c42bcbfed6890008a09012

@HirazawaUi HirazawaUi mentioned this pull request Mar 2, 2025
Open
20 tasks
@netlify Netlify
Copy link

netlify bot commented Mar 2, 2025

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5ff0239
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67c42bcbb979310008a97a2b
😎 Deploy Preview https://deploy-preview-49975--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tengqm
tengqm reviewed Mar 2, 2025
View reviewed changes
.../en/docs/reference/command-line-tools-reference/feature-gates/DisableNodeKubeProxyVersion.md
toVersion: "1.33.0"
- stage: deprecated
defaultValue: true
fromVersion: "1.33.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's happening to this gate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you are asking what changes have been made to this gate in version 1.33

We changed it to be enabled by default in 1.33. When the feature gate is enabled, we do not display the deprecated fields.

ref: kubernetes/kubernetes#129713

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So ... please clarify, what is "deprecated" ... the kubeProxyVersion field, or the gate? This feature gate is temporary and it is going away, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HirazawaUi @k8s-ci-robot @tengqm