Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New probes page #49968

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

AmarNathChary
Copy link
Contributor

This PR partially fixes issue #46886

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 1, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 1, 2025
@AmarNathChary
Copy link
Contributor Author

/kind documention

@k8s-ci-robot
Copy link
Contributor

@AmarNathChary: The label(s) kind/documention cannot be applied, because the repository doesn't have them.

In response to this:

/kind documention

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

netlify bot commented Mar 1, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 18eff1d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67c6a17437cce400089f6bbe
😎 Deploy Preview https://deploy-preview-49968--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


Probes are configured as part of the Pod specification in YAML manifests. Each probe can define multiple parameters to suit specific application requirements. Below are the details for configuring each type of probe:

#### Key Fields
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid H4 level of headers if possible.

- **`periodSeconds`**: Interval between probe attempts.
- **`timeoutSeconds`**: Maximum time to wait for a response.
- **`failureThreshold`**: Number of consecutive failures before the probe is considered failed.
- **`successThreshold`**: Number of consecutive successes before the probe is considered successful.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to highlight field names with BOTH teletype fonts and bold.
Simply make them teletype would be good enough.


An HTTP probe sends an HTTP GET request to a specific endpoint within the container. This is useful for applications exposing an HTTP server.

#### Example Configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again. An example doesn't need a subsection.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!


## gRPC Health Checks

Kubernetes can use the gRPC Health Check Protocol for monitoring gRPC services. The gRPC health check response includes different statuses that can be leveraged for configuring liveliness and readiness probes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"gRPC Health Check Protocol" is a term?
Why capitalize the first characters in each words?


## Best Practices

1. **Choose the Right Probe for the Use Case:**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need an ordered list here, right?

Why use bold fonts here?


<!-- overview -->

This page provides an overview of Probes. Probes in Kubernetes serve as a health checker for the containers, ensuring their reliability and availability within the pods. These diagnostic tools enable Kubernetes to monitor the health of the workloads and take appropriate actions when issues arise, like restarting unhealthy containers or temporarily removing pods from service endpoints. Configuring probes is essential for maintaining the stability, resilience, and overall performance of applications in the Kubernetes cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wrap the long lines as we do for other pages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the changes accordingly as suggested PTAL!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants