Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate ElasticIndexedJob to GA #46991

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Graduate ElasticIndexedJob to GA #46991

merged 1 commit into from
Jul 14, 2024

Conversation

ahg-g
Copy link
Member

@ahg-g ahg-g commented Jun 27, 2024

@k8s-ci-robot k8s-ci-robot added this to the 1.31 milestone Jun 27, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 27, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 27, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit cbea62f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/667d91bec83ad0000890ef42

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 27, 2024
@ahg-g ahg-g mentioned this pull request Jun 27, 2024
Closed
8 tasks
@netlify Netlify
Copy link

netlify bot commented Jun 27, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit cbea62f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/667d91be5e0b30000926e6c3
😎 Deploy Preview https://deploy-preview-46991--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shubham82
Copy link
Contributor

Holding this PR for now, as the corresponding upstream PR hasn’t been merged yet.
kubernetes/kubernetes#125751

/hold
(remove the hold label once the upstream changes are merged)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2024
@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 758d8fa0cabbda8cd3214456d93efc064079ed2e

@katcosgrove
Copy link
Contributor

/approve

Unhold when ready!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: katcosgrove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2024
dipesh-rawat
dipesh-rawat reviewed Jul 14, 2024
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc PR looks good to unhold now that the implementation for promoting the ElasticIndexedJob to GA has been merged into k/k as part of PR-125751

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit be3a417 into kubernetes:dev-1.31 Jul 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.31
Development

Successfully merging this pull request may close these issues.
6 participants
@ahg-g @Shubham82 @alculquicondor @k8s-ci-robot @katcosgrove @dipesh-rawat