KEP-3836 documentation for 1.30 #45678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
sig/docs
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
sftim
previously requested changes
Mar 26, 2024
...eference/command-line-tools-reference/feature-gates/kube-proxy-draining-terminating-nodes.md
Outdated
Show resolved
Hide resolved
alexanderConstantinescu
force-pushed
the
kep-3836
branch
from
1ce0f75 to
c94d2eb
Compare
sftim
reviewed
Mar 26, 2024
| @@ -488,6 +488,67 @@ route to ready node-local endpoints. If the traffic policy is `Local` and there | |||
| are no node-local endpoints, the kube-proxy does not forward any traffic for the | |||
| relevant Service. | |||
|
|
|||
There was a problem hiding this comment.
Even better IMO
Suggested change
| #### Traffic to terminating nodes | |
| {{< feature-state feature_gate_name="KubeProxyDrainingTerminatingNodes" >}} | |
We can add that after this merges in.
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 171fc9a0e432067800d98f84127ef594a945c5fa
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/milestone 1.30 |
This was referenced May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: kubernetes/enhancements#3836
Original implementation PR: kubernetes/kubernetes#116470
Copy of #45290 but targeting
dev-1.30instead