Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post-release blog article about changes to Pod resources API #42041

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

ffromani
Copy link
Contributor

@ffromani ffromani commented Jul 17, 2023

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 17, 2023
@ffromani ffromani changed the title blog: node: podresources API GA graduations WIP: blog: node: podresources API GA graduations Jul 17, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Jul 17, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 17, 2023
@ffromani
Copy link
Contributor Author

/hold

I mis-clicked and did NOT upload as draft ( :( ) so WIP+hold to prevent merge

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2023
@netlify
Copy link

netlify bot commented Jul 17, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b5f4cff
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64d666ba417d150008a91dbd
😎 Deploy Preview https://deploy-preview-42041--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ffromani
Copy link
Contributor Author

sorry for too early assign, my bad.

@ffromani
Copy link
Contributor Author

/unassign @onlydole

just way too early

@sftim
Copy link
Contributor

sftim commented Jul 19, 2023

/retitle [WIP] Add post-release blog article about changes to Pod resources API

@k8s-ci-robot k8s-ci-robot changed the title WIP: blog: node: podresources API GA graduations [WIP] Add post-release blog article about changes to Pod resources API Jul 19, 2023
@bradmccoydev
Copy link
Member

Hi Comms here for Release 1.28 we are checking in to see if you are going to complete this blog as it is due..?

@ffromani
Copy link
Contributor Author

ffromani commented Aug 1, 2023

Hi Comms here for Release 1.28 we are checking in to see if you are going to complete this blog as it is due..?

Hi, I'll be working on this blog post this week (week ending August 4)

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2023
@ffromani ffromani changed the title [WIP] Add post-release blog article about changes to Pod resources API Add post-release blog article about changes to Pod resources API Aug 2, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 2, 2023
@ffromani
Copy link
Contributor Author

ffromani commented Aug 2, 2023

the PR is now content-complete

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2023
@ffromani ffromani force-pushed the podres-ga-blog-post branch 2 times, most recently from 4c03f38 to a1de84f Compare August 9, 2023 06:21
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2023
@ffromani
Copy link
Contributor Author

ffromani commented Aug 9, 2023

/hold

need to fix the recommendations about the client package
[EDIT] will finalize this section and unhold by the end of the week (August 11) wort case [/EDIT]

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2023
@ffromani ffromani force-pushed the podres-ga-blog-post branch 3 times, most recently from f6a2476 to cbcaf55 Compare August 11, 2023 09:32
@ffromani
Copy link
Contributor Author

/hold cancel

In the last upload I made few minor fixes. I was looking for a good example of a client package, but I'm not yet in a position to recommend any, so I'm leaving this out from this blog post. The important part is that we really need to emphasize that reimplementing the client in a consumer project is still the recommended approach (!!!!), but this was already fixed in the past days.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2023
I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancements:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b9845e5a1fcb8b0b300e35f5d51d564826a1a930

image: podresources-monitor:latest # just for an example
volumeMounts:
- mountPath: /host-podresources
name: host-podresources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see usage of this with readOnly: true. Since it is a Directory and not a socket, it should work OK and will limit the exposure. Changing it to readonly will require to add some explanation below explaining the difference between socket non-readonly and directory mount being readonly

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm certainly puzzled about how a read-only mount might let you make a read-write connection to a socket within that mount! That might separately merit an explanation in https://k8s.io/docs/concepts/storage/volumes/#hostpath

@sftim
Copy link
Contributor

sftim commented Aug 13, 2023

/hold
Let's not merge this until v1.28 is released. OK to unhold once that has happened.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2023
@sftim
Copy link
Contributor

sftim commented Aug 15, 2023

LGTM for blog team.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SergeyKanzhelev, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@sftim
Copy link
Contributor

sftim commented Aug 15, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2f69ad0 into kubernetes:main Aug 15, 2023
7 checks passed
@ffromani ffromani deleted the podres-ga-blog-post branch August 22, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Published
Development

Successfully merging this pull request may close these issues.

7 participants