Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove -fs from troubleshooting command #4159

Closed
wants to merge 0 commits into from
Closed

Remove -fs from troubleshooting command #4159

wants to merge 0 commits into from

Conversation

zacharysarah
Copy link
Contributor

@zacharysarah zacharysarah commented Jun 22, 2017 •
edited by k8s-reviewable
Loading

Closes #1184

I tested the current docs command locally to verify that -fs silences errors. It's legit:

$ curl -fs -X PUT "http://${host}:${port}/v2/keys/_test"
$

After removing the -fs switch:

$ curl -X PUT "http://${host}:${port}/v2/keys/_test"
<html>
<head><title>400 Bad Request</title></head>
<body bgcolor="white">
<center><h1>400 Bad Request</h1></center>
<hr><center>nginx/1.12.0</center>
</body>
</html>

This change is Reviewable

@zacharysarah zacharysarah self-assigned this Jun 22, 2017
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 22, 2017
@zacharysarah
Copy link
Contributor Author

please reply here with a new comment and we'll verify

Testing.

@kubernetes kubernetes deleted a comment from k8s-ci-robot Jun 22, 2017
@zacharysarah
Copy link
Contributor Author

please reply here with a new comment and we'll verify

Testing.

@zacharysarah
Copy link
Contributor Author

Closing due to commit history uncleanness, will reopen as a new PR.

@zacharysarah zacharysarah mentioned this pull request Jun 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zacharysarah zacharysarah

Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zacharysarah @k8s-ci-robot