Update document for Azure LoadBalancer support. #4082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
chenopis
reviewed
Jun 20, 2017
| @@ -429,10 +429,18 @@ with the user-specified `loadBalancerIP`. If the `loadBalancerIP` field is not s | |||
| an ephemeral IP will be assigned to the loadBalancer. If the `loadBalancerIP` is specified, but the | |||
| cloud provider does not support the feature, the field will be ignored. | |||
|
|
|||
| #### Internal load balancer on AWS | |||
| Special notes for Azure: To use user-specified public type `loadBalancerIP`, a static type | |||
| public IP address resource need to be created at first, and it should be in the same resource | |||
|
Thanks for comment. Update pushed. |
|
ping @bprashanth |
jdumars
reviewed
Jul 12, 2017
| @@ -429,10 +429,18 @@ with the user-specified `loadBalancerIP`. If the `loadBalancerIP` field is not s | |||
| an ephemeral IP will be assigned to the loadBalancer. If the `loadBalancerIP` is specified, but the | |||
| cloud provider does not support the feature, the field will be ignored. | |||
|
|
|||
| #### Internal load balancer on AWS | |||
| Special notes for Azure: To use user-specified public type `loadBalancerIP`, a static type | |||
| public IP address resource needs to be created at first, and it should be in the same resource | |||
There was a problem hiding this comment.
public IP address resource needs to be created first, and it should be in the same resource
|
Added one small suggestion. Otherwise LGTM. |
chenopis
added a commit
that referenced
this pull request
Jul 28, 2017
…hub.io into netlify-move * 'master' of https://github.com/kubernetes/kubernetes.github.io: Simplify sentence minor correction for datastore storage folder Fix spelling error (#4528) Updated Getting Started Guide for vSphere Cloud Provider In links to ref pages, use {{page.version}}. Update backlinks to client libraries page Translate getting-started-guides/centos/centos_manual_config.md into Chinese update version No. to para. (#4442) Change deprecated `kubectl update` to `replace` (#4307) Revert "add host paths to psp (#3971)" docs/concepts/policy/pod-security-policy.md: update link to example. change the limit to request concepts/storage: fix minor typo in volumes.md kubeadm: Make tabs with information how to install 3rd-party CNI network solutions Add docs for running cloud-controller-manager with persistent volume labeling Update document for Azure LoadBalancer support. (#4082) Add note about rkt under CRI to rktnetes page (#4470) Delete redundant "see" (#4466) Allow importing of manifest files with tutorial import script # Conflicts: # docs/setup/independent/create-cluster-kubeadm.md # docs/tasks/administer-cluster/cpu-memory-limit.md # docs/tasks/configure-pod-container/security-context.md
jesscodez
pushed a commit
that referenced
this pull request
Sep 22, 2017
* Add doc for azure internal load balancer support. * Add note for user-specified 'loadBalancerIP' support on Azure. * Fix comment. * Fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document update for following 2 PRs:
This change is