Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh-cn] Sync and add anchors for tasks/access-application-cluster/* #40534

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

fenggw-fnst
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 6, 2023
@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label Apr 6, 2023
@k8s-ci-robot k8s-ci-robot requested a review from SataQiu April 6, 2023 07:53
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Apr 6, 2023
@netlify
Copy link

netlify bot commented Apr 6, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 10681a6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/642fe7f330839f0008708453
😎 Deploy Preview https://deploy-preview-40534--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@windsonsea
Copy link
Member

windsonsea commented Apr 6, 2023

These 5 fives are in sync when you run ./scripts/lsync.sh to check differences from en source.

You need to confirm the synchronization conditions with en version one by one, line by line, before merging.

@fenggw-fnst
Copy link
Contributor Author

Thanks for reply.
I have checked these files with ./scripts/lsync.sh, and it shows that list-all-running-container-images.md needs to be updated, but actually it is in sync at present. Other files under tasks/access-application-cluster/ are all in sync.

This PR aims to:

  1. Resync (refresh) the lsync.sh result for list-all-running-container-images.md.
  2. Add anchors for the files that lack them.

You need to confirm the synchronization conditions with en version one by one, line by line, before merging.

Understood, for manually checking the sync status, I'd like to open another PR to fix them if I do find something out of sync, since manual proofreading may take a lot of time.

@windsonsea
Copy link
Member

The reason of in sync from ./scripts/lsync.sh is some contributors only changed part of out-of-sync content, so it's not encouraged to merge partial change in general. This behavior will invalidate the command ./scripts/lsync.sh.

@fenggw-fnst
Copy link
Contributor Author

The reason of in sync from ./scripts/lsync.sh is some contributors only changed part of out-of-sync content, so it's not encouraged to merge partial change in general. This behavior will invalidate the command ./scripts/lsync.sh.

Thanks for explaining, indeed, that's why every time I update a single page, I take a quick look at the entire text to see if there's anything out of sync elsewhere.

But in my understanding, ./scripts/lsync.sh tells us whether the page needs to be synced or not, if a page is in sync, then it is safe to do some specific fixes. If it's not in sync, then we have to sync it first, and then do the fix.

If we have to manually proofread the entire page when we want to modify some specific problems on the basis that the page is still showd in sync, then ./scripts/lsync.sh loses its value.

For this PR, my main purpose is to fix them for the anchor aspect and this will make our zh-cn pages better. I'm not saying I won't check them out manually, I just mean that it doesn't break the sync status.

@tengqm
Copy link
Contributor

tengqm commented Apr 7, 2023

/approve
/lgtm
/hold

Feel free to lift the hold if the pages are confirmed to be in sync.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f3b912b1f8ca919c176bf0bfeb243471c11d6018

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2023
@k8s-ci-robot k8s-ci-robot requested a review from tengqm April 7, 2023 06:37
@fenggw-fnst
Copy link
Contributor Author

Updated, now they are all confirmed to be in sync, PTAL, thanks.
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2023
Signed-off-by: Guangwen Feng <fenggw-fnst@fujitsu.com>
@windsonsea
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f8f4fd4b981b732874afed15fa03495962355b6d

@k8s-ci-robot k8s-ci-robot merged commit 029cf8d into kubernetes:main Apr 7, 2023
@fenggw-fnst fenggw-fnst deleted the add-anchors branch April 10, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants