Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn] sync rbac #40524

Merged
merged 1 commit into from
Apr 7, 2023
Merged

[zh-cn] sync rbac #40524

merged 1 commit into from
Apr 7, 2023

Conversation

asa3311
Copy link
Contributor

@asa3311 asa3311 commented Apr 5, 2023

sync rbac

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 5, 2023
@k8s-ci-robot k8s-ci-robot requested a review from SataQiu April 5, 2023 13:44
@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label Apr 5, 2023
@k8s-ci-robot k8s-ci-robot requested a review from ydFu April 5, 2023 13:44
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 5, 2023
@netlify
Copy link

netlify bot commented Apr 5, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 43f5b0c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/642f65b49a4a550008eac57d
😎 Deploy Preview https://deploy-preview-40524--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

windsonsea
windsonsea reviewed Apr 6, 2023
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has much more differences with en version. Hope you can sync them all rather than picking up a para. Thanks.
You can run this command on your local main branch to check details:

./scripts/lsync.sh content/zh-cn/docs/reference/access-authn-authz/rbac.md

image

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 6, 2023
@asa3311
Copy link
Contributor Author

asa3311 commented Apr 6, 2023

已更新，都是英文文本格式化，对中文基本无改动。

@tengqm
Copy link
Contributor

tengqm commented Apr 6, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d82ce2b11b4ba1165128dbaebcde2aff305bd67b

@asa3311
sync rbac
43f5b0c 
sync rbac
@windsonsea
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windsonsea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit a1c6636 into kubernetes:main Apr 7, 2023
@Zhuzhenghao Zhuzhenghao mentioned this pull request Apr 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windsonsea windsonsea windsonsea left review comments

@SataQiu SataQiu Awaiting requested review from SataQiu

@ydFu ydFu Awaiting requested review from ydFu

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asa3311 @tengqm @k8s-ci-robot @windsonsea