Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] Update install-kubeadm.md #39525

Merged
merged 6 commits into from
Feb 27, 2023
Merged

[ja] Update install-kubeadm.md #39525

merged 6 commits into from
Feb 27, 2023

Conversation

yayoimizuha
Copy link
Contributor

@yayoimizuha yayoimizuha commented Feb 18, 2023 •
edited
Loading

In Japanese page,it says old method curl -s https://packages.cloud.google.com/apt/doc/apt-key.gpg | sudo apt-key add - .
But,recent versions of Ubuntu,they shows warning about apt-key add .
and I also see English page, it says newer method.
so I copied English page's code and translate some comments in Japanese.

@yayoimizuha
[ja] Update install-kubeadm.md
2ff785d 
In Japanese page,it says old method  ```curl -s https://packages.cloud.google.com/apt/doc/apt-key.gpg | sudo apt-key add -``` .
But,recent versions of Ubuntu,they shows warning about apt-key add .  
and I also see English page, it says newer method.
so I copied English page's code and translate some comments in Japanese.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 18, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot requested a review from bells17 February 18, 2023 17:31
@k8s-ci-robot k8s-ci-robot added the language/ja Issues or PRs related to Japanese language label Feb 18, 2023
@k8s-ci-robot k8s-ci-robot requested a review from t-inu February 18, 2023 17:31
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 18, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @yayoimizuha!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 18, 2023
t-inu
t-inu reviewed Feb 20, 2023
View reviewed changes
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating.
This page is outdated overall, but I reviewed it as an update to one of the tabs.

@yayoimizuha
Copy link
Contributor Author

OK,if I have a time ,I'll translate all off this page.

yayoimizuha and others added 5 commits February 26, 2023 11:06
@yayoimizuha @t-inu
Update content/ja/docs/setup/production-environment/tools/kubeadm/ins…
7bc3d62 
…tall-kubeadm.md

Co-authored-by: Toshiaki Inukai <82919057+t-inu@users.noreply.github.com>
@yayoimizuha @t-inu
Update content/ja/docs/setup/production-environment/tools/kubeadm/ins…
28963c6 
…tall-kubeadm.md

Co-authored-by: Toshiaki Inukai <82919057+t-inu@users.noreply.github.com>
@yayoimizuha @t-inu
Update content/ja/docs/setup/production-environment/tools/kubeadm/ins…
cdb1a9c 
…tall-kubeadm.md

Co-authored-by: Toshiaki Inukai <82919057+t-inu@users.noreply.github.com>
@yayoimizuha @t-inu
Update content/ja/docs/setup/production-environment/tools/kubeadm/ins…
91714b4 
…tall-kubeadm.md

Co-authored-by: Toshiaki Inukai <82919057+t-inu@users.noreply.github.com>
@yayoimizuha @t-inu
Update content/ja/docs/setup/production-environment/tools/kubeadm/ins…
58917de 
…tall-kubeadm.md

Co-authored-by: Toshiaki Inukai <82919057+t-inu@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Feb 26, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 7bc3d62
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63fabe9ed530cb0009c9b37f
😎 Deploy Preview https://deploy-preview-39525--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 26, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 58917de
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63fabecd6a683a0008b7ce05
😎 Deploy Preview https://deploy-preview-39525--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

t-inu
t-inu approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for applying the suggestions.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e98ea4070b646fe7909f983fbbf89e92bde8de7a

@t-inu
Copy link
Member

t-inu commented Feb 27, 2023

@yayoimizuha
If you have an opportunity to update the entire page, please create a new PR.
In that case, it is better to create an issue first.

@t-inu
Copy link
Member

t-inu commented Feb 27, 2023

/assign @inductor @nasa9084
Could you check this PR?

@inductor
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inductor, t-inu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 33c2953 into kubernetes:main Feb 27, 2023
@yayoimizuha yayoimizuha deleted the patch-1 branch February 28, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inductor inductor inductor approved these changes

@t-inu t-inu t-inu approved these changes

@bells17 bells17 Awaiting requested review from bells17

Assignees

@nasa9084 nasa9084

@inductor inductor

@t-inu t-inu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yayoimizuha @k8s-ci-robot @t-inu @inductor @nasa9084