Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] Add ja to the paths of debug pages #39020

Merged
merged 2 commits into from
Feb 2, 2023
Merged

[ja] Add ja to the paths of debug pages #39020

merged 2 commits into from
Feb 2, 2023

Conversation

shogohida
Copy link
Contributor

@shogohida shogohida commented Jan 21, 2023 •
edited
Loading

Signed-off-by: Shogo Hida shogo.hida@gmail.com

Fixes #38797

This PR changes the paths of debug pages. The example shown on the issue is below.

  • Only add "/ja"
    • e.g.: /docs/tasks/debug/debug-cluster/audit/ -> /ja/docs/tasks/debug/debug-cluster/audit/

@shogohida
Add ja to debug pages
3eb0089 
Signed-off-by: Shogo Hida <shogo.hida@gmail.com>
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 21, 2023
@shogohida shogohida changed the title Add ja to debug pages [ja] Add ja to debug pages Jan 21, 2023
@shogohida shogohida changed the title [ja] Add ja to debug pages [ja] Add ja to the paths of debug pages Jan 21, 2023
@netlify
Copy link

netlify bot commented Jan 21, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e5a5329
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63ce7775ac5df3000928d4a6
😎 Deploy Preview https://deploy-preview-39020--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Arhell
Arhell reviewed Jan 21, 2023
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @nasa9084

@bells17
Copy link
Contributor

bells17 commented Jan 21, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a4fe42037f9ba84bee8ce1433d58f00d1ce128bc

@atoato88
Copy link
Contributor

LGTM

t-inu
t-inu reviewed Jan 23, 2023
View reviewed changes
content/ja/docs/tutorials/stateful-application/mysql-wordpress-persistent-volume.md Outdated
@@ -234,7 +234,7 @@ WordPressのインストールをこのページのまま放置してはいけ
## {{% heading "whatsnext" %}}


* [イントロスペクションとデバッグ](/docs/tasks/debug/debug-application)についてさらに学ぶ
* [イントロスペクションとデバッグ](/ja/docs/tasks/debug/debug-application)についてさらに学ぶ
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [イントロスペクションとデバッグ](/ja/docs/tasks/debug/debug-application)についてさらに学ぶ
* [イントロスペクションとデバッグ](/ja/docs/tasks/debug/debug-application/debug-running-pod/)についてさらに学ぶ

Suggestion to match this link to the original.

website/content/en/docs/tutorials/stateful-application/mysql-wordpress-persistent-volume.md

Line 239 in 38418fb

* Learn more about [Introspection and Debugging](/docs/tasks/debug/debug-application/debug-running-pod/)

This fix can also be categorized as "Change path and add ja" in the issue #38797, but can fix it in this PR.
Because this is a special case unrelated to directory structure changes about debug pages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review! I fixed the path by adding /debug-running-pod/. Please check it.

e5a5329

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2023
@k8s-ci-robot k8s-ci-robot requested a review from nasa9084 January 23, 2023 12:03
@shogohida shogohida requested review from t-inu and removed request for atoato88, bells17 and nasa9084 January 23, 2023 12:05
t-inu
t-inu approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 69c13354d67dd7944d66b2ea05f44c8641096dff

@shogohida
Copy link
Contributor Author

/assign @nasa9084

nasa9084
nasa9084 reviewed Feb 2, 2023
View reviewed changes
Copy link
Member

@nasa9084 nasa9084 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084, t-inu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 01867e3 into kubernetes:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@nasa9084 nasa9084 nasa9084 left review comments

@t-inu t-inu t-inu approved these changes

Assignees

@bells17 bells17

@nasa9084 nasa9084

@t-inu t-inu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ja] Some links to debug page are outdated
7 participants
@shogohida @bells17 @k8s-ci-robot @atoato88 @nasa9084 @Arhell @t-inu