Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark CSIMigrationAzureFile as GA #37813

Closed
wants to merge 3 commits into from
Closed

mark CSIMigrationAzureFile as GA #37813

wants to merge 3 commits into from

Conversation

andyzhangx
Copy link
Member

mark CSIMigrationAzureFile as GA, refer to kubernetes/kubernetes#113160

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 9, 2022
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign onlydole for approval by writing /assign @onlydole in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 9, 2022
sftim
sftim reviewed Nov 9, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Please have a look at https://kubernetes.io/docs/concepts/storage/volumes/#azurefile - there may be some more content to update.

content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated Show resolved Hide resolved
andyzhangx and others added 2 commits November 9, 2022 22:05
@andyzhangx @sftim
Update content/en/docs/reference/command-line-tools-reference/feature…
1030e4a 
…-gates.md

Co-authored-by: Tim Bannister <tim@scalefactory.com>
@andyzhangx
Update volumes.md
6e51cd3
@andyzhangx
Copy link
Member Author

Thanks.

Please have a look at https://kubernetes.io/docs/concepts/storage/volumes/#azurefile - there may be some more content to update.

@sftim thanks, I have updated.

@netlify
Copy link

netlify bot commented Nov 9, 2022

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 25dcf9c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/636bb139a383f5000982a278
😎 Deploy Preview https://deploy-preview-37813--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 9, 2022

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 6e51cd3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/636bb439445cdc0008e80fe4
😎 Deploy Preview https://deploy-preview-37813--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tengqm
Copy link
Contributor

tengqm commented Nov 9, 2022

This one should be proposed against the dev-1.26 branch rather than the main branch.

@xing-yang
Copy link
Contributor

The content looks good to me. As mentioned by @tengqm, please submit to dev-1.26 branch.

@sftim
Copy link
Contributor

sftim commented Nov 9, 2022

Given #37813 (comment)

/hold

OK to unhold once that's fixed.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2022
@andyzhangx
Copy link
Member Author

opened a new PR for dev-1.26 branch: #37825

@jsafrane
Copy link
Member

/close
in favor of #37825

@k8s-ci-robot
Copy link
Contributor

@jsafrane: Closed this PR.

In response to this:

/close
in favor of #37825

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andyzhangx @k8s-ci-robot @tengqm @xing-yang @sftim @jsafrane