Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blog for non-graceful node shutdown beta #37583

Merged
merged 5 commits into from
Dec 13, 2022
Merged

Add blog for non-graceful node shutdown beta #37583

merged 5 commits into from
Dec 13, 2022

Conversation

xing-yang
Copy link
Contributor

@xing-yang xing-yang commented Oct 29, 2022 •
edited
Loading

This PR adds a blog for kubernetes/enhancements#2268.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Oct 29, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 29, 2022
@netlify
Copy link

netlify bot commented Oct 29, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9175b3c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/639782b7d82fc100085ee884
😎 Deploy Preview https://deploy-preview-37583--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sftim
Copy link
Contributor

sftim commented Oct 29, 2022

/retitle [WIP] Add blog for non-graceful node shutdown

It's a placeholder.

@k8s-ci-robot k8s-ci-robot changed the title Add blog for non-graceful node shutdown [WIP] Add blog for non-graceful node shutdown Oct 29, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2022
@xing-yang xing-yang mentioned this pull request Nov 1, 2022
Closed
@fsmunoz
Copy link
Contributor

fsmunoz commented Nov 16, 2022

Hello @xing-yang , v1.26 Comms lead here. This feature blog is on a feature tracked for release, the deadline for submitting a draft is the 29th of November; this should be considered the hard limit since we will need to review/edit/discuss the draft, so if at all possible it's better to submit it earlier to avoid any problems.

Any doubts, we're here to help!

@xing-yang
Copy link
Contributor Author

Thanks @fsmunoz for the reminder! Will update soon.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 20, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 21, 2022
@xing-yang xing-yang changed the title [WIP] Add blog for non-graceful node shutdown Add blog for non-graceful node shutdown Nov 21, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2022
@xing-yang xing-yang changed the title Add blog for non-graceful node shutdown Add blog for non-graceful node shutdown beta Nov 21, 2022
@xing-yang
Copy link
Contributor Author

cc @sonasingh46

@xing-yang
Copy link
Contributor Author

Hi @fsmunoz, this blog is ready to review. Thanks.

YuikoTakada
YuikoTakada reviewed Nov 24, 2022
View reviewed changes
Copy link
Contributor

@YuikoTakada YuikoTakada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. I left just one comment.

content/en/blog/_posts/2022-12-06-non-graceful-node-shutdown-to-beta.md Outdated Show resolved Hide resolved
@xing-yang
Copy link
Contributor Author

@YuikoTakada, addressed your comment. PTAL. Thanks.

@fsmunoz
Copy link
Contributor

fsmunoz commented Nov 30, 2022

Hello, Comms Lead for v1.26 here: this Feature Blog PR is confirmed for the post-release Feature Blog series. We will add the publishing date in the next days. Thank you for your work!

@fsmunoz
Copy link
Contributor

fsmunoz commented Dec 7, 2022

@xing-yang it would be ideal if we could get this Ready to Publish by tomorrow, the release date, so that we can be sure that regardless of minor edits/improvements we have it ready to publish at the defined date. Many thanks!

@xing-yang
Copy link
Contributor Author

@fsmunoz @divya-mohan0209 @sftim @YuikoTakada All comments are addressed. Please take a look. Thanks!

@YuikoTakada
Copy link
Contributor

Thank you for updating.
lgtm!

sftim
sftim reviewed Dec 9, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

I'd prefer to see a few more tweaks - see inline feedback.

content/en/blog/_posts/2022-12-16-non-graceful-node-shutdown-to-beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-12-16-non-graceful-node-shutdown-to-beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-12-16-non-graceful-node-shutdown-to-beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-12-16-non-graceful-node-shutdown-to-beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-12-16-non-graceful-node-shutdown-to-beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-12-16-non-graceful-node-shutdown-to-beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-12-16-non-graceful-node-shutdown-to-beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-12-16-non-graceful-node-shutdown-to-beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-12-16-non-graceful-node-shutdown-to-beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-12-16-non-graceful-node-shutdown-to-beta.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 9, 2022
@sftim
Copy link
Contributor

sftim commented Dec 11, 2022

add a line saying that "the cluster operator can automate this process by automatically applying the out-of-service taint if there is a programmatic way to determine that the node is really shut down and there isn’t IO between the node and storage and then automatically remove the taint after the workload fails over successfully to another running node and that the shutdown node has been recovered".

Sound good to me. or similar wording.

sftim
sftim reviewed Dec 11, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

More fixes if you want to make them.

@xing-yang what's your preference? Tweaks, or get it merged as-is?

content/en/blog/_posts/2022-12-16-non-graceful-node-shutdown-to-beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-12-16-non-graceful-node-shutdown-to-beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-12-16-non-graceful-node-shutdown-to-beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-12-16-non-graceful-node-shutdown-to-beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-12-16-non-graceful-node-shutdown-to-beta.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2c58427ccbcdc084af3a0b856793154936192177

@sftim
Copy link
Contributor

sftim commented Dec 11, 2022

/hold cancel

Kubernetes 1.26 is released.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2022
@xing-yang
Copy link
Contributor Author

More fixes if you want to make them.
@xing-yang what's your preference? Tweaks, or get it merged as-is?

@sftim Let me address the comments today. Thanks.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2022
@xing-yang
Copy link
Contributor Author

@sftim All comments are addressed. PTAL. Thanks.

sftim
sftim reviewed Dec 13, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Let's merge it

/lgtm
/approve

content/en/blog/_posts/2022-12-16-non-graceful-node-shutdown-to-beta.md
slug: kubernetes-1-26-non-graceful-node-shutdown-beta
---

**Author:** Xing Yang (VMware), Ashutosh Kumar (VMware)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit)

Suggested change
**Author:** Xing Yang (VMware), Ashutosh Kumar (VMware)
**Authors:** Xing Yang (VMware), Ashutosh Kumar (VMware)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 119447368d84bee190dac48c529480e615e01ce9

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 28caaa7 into kubernetes:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@YuikoTakada YuikoTakada YuikoTakada left review comments

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

Assignees

@divya-mohan0209 divya-mohan0209

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@xing-yang @sftim @fsmunoz @YuikoTakada @gnufied @k8s-ci-robot @divya-mohan0209