-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog: add dynamic resource allocation feature blog post #37434
blog: add dynamic resource allocation feature blog post #37434
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Hello @pohly , v1.26 Comms lead here. This feature blog is on a feature tracked for release, the deadline for submitting a draft is the 29th of November; this should be considered the hard limit since we will need to review/edit/discuss the draft, so if at all possible it's better to submit it earlier to avoid any problems. Any doubts, we're here to help! |
Hello @pohly , we're doing a global reminder about submitting a draft for review for all opted-in feature blogs. If it's at all possible, it is very helpful for the release team to have drafts submitted for review before the hard deadline date, to better plan the release dates and avoid missing out. Thank you! |
46f6c06
to
ccfa6fc
Compare
ccfa6fc
to
f3ac606
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick pass
085461e
to
794954c
Compare
I've pushed the update: https://github.com/kubernetes/website/compare/085461ea8fd98fc7111fe9754a2889cff5bd72c2..794954c5a0f4306d8441194cc235daecfdd2e9fc - please ignore the unrelated blog post, I rebased accidentally instead of just squashing. |
In another terminal, run the kubelet plugin: | ||
|
||
```console | ||
$ sudo mkdir -p /var/run/cdi && sudo chmod a+rwx /var/run/cdi /var/lib/kubelet/plugins_registry /var/lib/kubelet/plugins/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be part of the "setup" script from above.
Independently, are these three necessary? I have never needed to do this in my environment:
sudo chmod a+rwx /var/run/cdi
sudo chmod a+rwx /var/lib/kubelet/plugins_registry
sudo chmod a+rwx /var/lib/kubelet/plugins/
If those are not actually necessary, then the whole setup script would be:
$ cat run-k8s.sh
#!/usr/bin/env bash
sudo rm -rf /tmp/kube*
sudo rm -rf /var/run/kubernetes
sudo mkdir -p /var/run/cdi
export RUNTIME_CONFIG=resource.k8s.io/v1alpha1
export FEATURE_GATES=DynamicResourceAllocation=true
export DNS_ADDON="coredns"
export CGROUP_DRIVER=systemd
export CONTAINER_RUNTIME_ENDPOINT=unix:///var/run/crio/crio.sock
export LOG_LEVEL=6
export ENABLE_CSI_SNAPSHOTTER=false
export API_SECURE_PORT=6444
export ALLOW_PRIVILEGED=1
export PATH=$(pwd)/third_party/etcd:$PATH
./hack/local-up-cluster.sh -O
Where you then run:
$ hack/install-etcd.sh
...
$ ./run-k8s.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have never needed to do this in my environment:|
Are you running the "go" command with the kubelet plugin as root? Then it is not needed. But when using a non-privileged user account it is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've never tried to run things exactly as you described here. I always deploy privileged pods, so that probably explains it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That said, would it make sense to just have them run the go
command as sudo
so as not to corrupt their environment for future "real" deployments of the components as pods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running "sudo go", it will not use the already populated Go cache of the current user. Let me add that as explanation and also point out that permissions should get restored when done.
eee479b
to
8220c8b
Compare
Another update... |
8220c8b
to
d9de2ca
Compare
d9de2ca
to
0a23be1
Compare
d0a93fe
to
f41da92
Compare
Hello, Comms Lead for v1.26 here: this Feature Blog PR is confirmed for the post-release Feature Blog series. We will add the publishing date in the next days. Thank you for your work! |
Hello, Comms Lead for v1.26 here. The publication order and date for the Feature Blog series has been finalised and the tracking board updated (cf. discussion). The publication date for this article is 15-12-2022 (December 15). Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
This is a big change to Kubernetes and so, not unrelated, I have a lot of feedback. My hope is that every comment is useful.
Anything I've called out as a question or a nit is an opportunity for you to revise things, but not a mandate. It'd be good to at least get an answer for each question I've asked. I know there were quite a few.
Please prioritize setting the publication date to the 15th of December, and change |
Holding until the release day. |
I'll squash and rename once we are done with the review. |
We'd like to get this as close as possible to being good to publish. We don't have to clear every feedback item to be able to merge, but we do have to get the date right. |
10a0937
to
05f2826
Compare
I've renamed the file to |
content/en/blog/_posts/2022-12-15-dynamic-resource-allocation-alpha/index.md
Outdated
Show resolved
Hide resolved
/approve Not adding formal LGTM yet as there are some bits of feedback pending. However, we could merge this as-is if need be. |
This feature got added as alpha in 1.26. kubernetes/enhancements#3063
1ce66ee
to
7008f54
Compare
/lgtm |
LGTM label has been added. Git tree hash: a198af050cf8288577990331561569a7f069b6b5
|
OK to unhold once Kubernetes v1.26 is released |
Marking this Ready for Publishing in Comms tracking, thank you for all the work - minor edits/reviews are still doable until the release date. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fsmunoz, klueska, sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Assuming that the feature goes into 1.26 as alpha, this will become a blog post about it.kubernetes/enhancements#3063