Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hi] Localize application-architect.md #36084

Merged
merged 4 commits into from
Dec 22, 2022
Merged

[hi] Localize application-architect.md #36084

merged 4 commits into from
Dec 22, 2022

Conversation

bishal7679
Copy link
Member

Signed-off-by: Bishal Das bishalhnj127@gmail.com

Localizes content/en/docs/reference/glossary/application-architect.md to Hindi content/hi/docs/reference/glossary/application-architect.md

Fixes :- #35944

@bishal7679
Add application-architect.md
88607e8 
Signed-off-by: Bishal Das <bishalhnj127@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 18, 2022
@k8s-ci-robot k8s-ci-robot added the language/hi Issues or PRs related to Hindi language label Aug 18, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 18, 2022
@bishal7679
Copy link
Member Author

@divya-mohan0209 @anubha-v-ardhan
Could you please leave some suggestion for this PR
It would be really helpful

__
sema-logo  Summary: 🛠️ This code needs a fix

@bishal7679
Copy link
Member Author

/assign @mittalyashu

__
sema-logo  Summary: 🛠️ This code needs a fix

divya-mohan0209
divya-mohan0209 reviewed Aug 19, 2022
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions, hope you find them helpful!

content/hi/docs/reference/glossary/application-architect.md Outdated
date: 2018-04-12
full_link:
short_description: >
किसी एप्लिकेशन के उच्च-स्तरीय डिज़ाइन के लिए जिम्मेदार व्यक्ति।
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't रचना be better than the literal translation of design?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes Actually I was thinking to use रचना but anyone might get confused with design
so I did not use it
Nice suggestion 👍

__
sema-logo  Summary: 🛠️ This code needs a fix  |  Tags: Inefficient

content/hi/docs/reference/glossary/application-architect.md Outdated
- user-type
---

किसी एप्लिकेशन के उच्च-स्तरीय डिज़ाइन के लिए जिम्मेदार व्यक्ति।
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

content/hi/docs/reference/glossary/application-architect.md Outdated

<!--more-->

एक आर्किटेक्ट यह सुनिश्चित करता है कि एक ऐप का कार्यान्वयन इसे अपने आसपास के घटकों के साथ एक स्केलेबल, रखरखाव योग्य तरीके से बातचीत करने की अनुमति देता है। आसपास के घटकों में डेटाबेस, लॉगिंग इन्फ्रास्ट्रक्चर और अन्य माइक्रोसर्विसेज शामिल हैं।
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

कार्यान्वयन means execution. Don't we mean to say execution environment in this?

@bishal7679
updated application-architect.md
d4a593b 
Signed-off-by: Bishal Das <bishalhnj127@gmail.com>
@bishal7679
updated application-architect.md
09c8898 
Signed-off-by: Bishal Das <bishalhnj127@gmail.com>
@rolfedh rolfedh mentioned this pull request Aug 23, 2022
Closed
@bishal7679 bishal7679 changed the base branch from dev-1.22-hi.1 to main September 2, 2022 12:07
@divya-mohan0209
Copy link
Contributor

@bishal7679 : PTAL at this PR whenever free.

@divya-mohan0209
Copy link
Contributor

@bishal7679 : Please do you have the cycles to check this PR & work on it?

@bishal7679
Copy link
Member Author

@bishal7679 : Please do you have the cycles to check this PR & work on it?

Extremely sorry @divya-mohan0209 its just slipped out from my looking. I am just checking it.
Could you help here?
what should we use replacing the meaning of implementation word in hindi instead of कार्यान्वयन???

@divya-mohan0209
Copy link
Contributor

@bishal7679 I'd recommend अमल since it seems simpler.

Also, you'll need to sync your fork and pull the latest branch changes for ALL your PRs

@netlify
Copy link

netlify bot commented Dec 20, 2022

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 051d451
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63a14cea92b35900089be418
😎 Deploy Preview https://deploy-preview-36084--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bishal7679
Copy link
Member Author

@divya-mohan0209 I think now It's good to go. WDYT??

divya-mohan0209
divya-mohan0209 reviewed Dec 20, 2022
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1989183cfabfb05dcf225cce168cc88085f511cf

@divya-mohan0209
Copy link
Contributor

@Babapool @verma-kunal @Garima-Negi @anubha-v-ardhan : PTAL

Babapool
Babapool reviewed Dec 22, 2022
View reviewed changes
Copy link
Member

@Babapool Babapool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

divya-mohan0209
divya-mohan0209 reviewed Dec 22, 2022
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking approval from comment by @Babapool and approving the PR.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit 475c76f into kubernetes:main Dec 22, 2022
@divya-mohan0209 divya-mohan0209 mentioned this pull request Jan 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@Babapool Babapool Babapool left review comments

@anubha-v-ardhan anubha-v-ardhan Awaiting requested review from anubha-v-ardhan

Assignees

@divya-mohan0209 divya-mohan0209

@mittalyashu mittalyashu

@Babapool Babapool

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/hi Issues or PRs related to Hindi language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bishal7679 @divya-mohan0209 @k8s-ci-robot @Babapool @mittalyashu