Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh]Sync reference-14 #33842

Merged
merged 1 commit into from
May 20, 2022
Merged

[zh]Sync reference-14 #33842

merged 1 commit into from
May 20, 2022

Conversation

nameYULI
Copy link

related issue: #33478
reference-14

580	165	content/en/docs/reference/using-api/api-concepts.md

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/zh Issues or PRs related to Chinese language labels May 20, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 20, 2022
@my-git9
Copy link
Member

my-git9 commented May 20, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 49f0a74370f2d26d14fe9577f8f284f82ff941ed

@tengqm
Copy link
Contributor

tengqm commented May 20, 2022

This is an improvement to the previous sync.

[zh]Sync reference-14
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2022
@k8s-ci-robot k8s-ci-robot requested a review from my-git9 May 20, 2022 13:21
@tengqm
Copy link
Contributor

tengqm commented May 20, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b30738b8cabc49d733b718a57a3fd481c6017e82

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit a5907b3 into kubernetes:main May 20, 2022
@sftim sftim mentioned this pull request May 21, 2022
@sftim
Copy link
Contributor

sftim commented May 21, 2022

@nameYULI it turned out that these changes led to the website build not working. Would you be willing to make a new PR (based on the latest main branch) that does the same thing? We'll make sure to test that that works; if you can, please also test that locally in case the same issue arises.

@sftim
Copy link
Contributor

sftim commented May 21, 2022

I think the problem may have only showed up after the merge; our Netlify system builds the branch and not a simulated merge.

(if you want a bit more context on what that means, see actions/checkout#15).

Anyway, these changes still need doing, that's the short version. Thank you for sending them in and I hope you will be willing to try once more.

@tengqm
Copy link
Contributor

tengqm commented May 21, 2022

@nameYULI Please manually rework this PR. We are losing track of the change date for this file. I hoped that it can be fixed in an easy way, but ... the whole PR is now reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants