-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[zh]Sync reference-14 #33842
[zh]Sync reference-14 #33842
Conversation
/lgtm |
LGTM label has been added. Git tree hash: 49f0a74370f2d26d14fe9577f8f284f82ff941ed
|
This is an improvement to the previous sync. |
[zh]Sync reference-14
/approve |
LGTM label has been added. Git tree hash: b30738b8cabc49d733b718a57a3fd481c6017e82
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@nameYULI it turned out that these changes led to the website build not working. Would you be willing to make a new PR (based on the latest main branch) that does the same thing? We'll make sure to test that that works; if you can, please also test that locally in case the same issue arises. |
I think the problem may have only showed up after the merge; our Netlify system builds the branch and not a simulated merge. (if you want a bit more context on what that means, see actions/checkout#15). Anyway, these changes still need doing, that's the short version. Thank you for sending them in and I hope you will be willing to try once more. |
@nameYULI Please manually rework this PR. We are losing track of the change date for this file. I hoped that it can be fixed in an easy way, but ... the whole PR is now reverted. |
related issue: #33478
reference-14