Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow marking blog posts as evergreen and exempt from outdated warning #31934

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Allow marking blog posts as evergreen and exempt from outdated warning #31934

merged 1 commit into from
Feb 28, 2022

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Feb 27, 2022 •
edited
Loading

fixes #31778

The guide to contributing blog posts says:

  • Blog posts should aim to be future proof
    • Given the development velocity of the project, we want evergreen content that won't require updates to stay accurate for the reader.

Blog posts that follow that guide should be able to skip the "outdated" content warning placed on posts older than a year

Before:
https://kubernetes.io/blog/2020/08/26/kubernetes-release-1.19-accentuate-the-paw-sitive/

After:
https://deploy-preview-31934--kubernetes-io-main-staging.netlify.app/blog/2020/08/26/kubernetes-release-1.19-accentuate-the-paw-sitive/

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 27, 2022
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 27, 2022
@netlify
Copy link

netlify bot commented Feb 27, 2022 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: b19e4ff

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/621bfa663da6c700080f1a1c

😎 Browse the preview: https://deploy-preview-31934--kubernetes-io-main-staging.netlify.app

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 27, 2022
@liggitt liggitt changed the title Allow marking some blog posts as evergreen and exempt from outdated warning Allow marking blog posts as evergreen and exempt from outdated warning Feb 27, 2022
@liggitt liggitt mentioned this pull request Feb 27, 2022
Closed
@tengqm
Copy link
Contributor

tengqm commented Feb 27, 2022

LGTM with a minor suggestion.

@sftim
Copy link
Contributor

sftim commented Feb 27, 2022

/area web-development
/approve

LGTM

With or without that nit highlighted by @tengqm, this is a nice and welcome improvement.

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Feb 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2022
@tengqm
Copy link
Contributor

tengqm commented Feb 28, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fe8521e61c7d2f37eaef74920c48d92b78a17a0b

@k8s-ci-robot k8s-ci-robot merged commit 879f4d4 into kubernetes:main Feb 28, 2022
@liggitt liggitt deleted the evergreen branch February 28, 2022 00:35
@sftim sftim mentioned this pull request Sep 26, 2022
Closed
@sftim sftim mentioned this pull request Oct 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@jimangel jimangel Awaiting requested review from jimangel

@sftim sftim Awaiting requested review from sftim

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow exempting blog articles from staleness notice
4 participants
@liggitt @tengqm @sftim @k8s-ci-robot