Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hi] Add content/hi/docs/setup/production-environment/turnkey-solutions.md #29966

Closed
wants to merge 1 commit into from
Closed

[hi] Add content/hi/docs/setup/production-environment/turnkey-solutions.md #29966

wants to merge 1 commit into from

Conversation

indevi
Copy link

@indevi indevi commented Oct 8, 2021

Part of Ongoing Effort:#29353

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 8, 2021
@k8s-ci-robot k8s-ci-robot added the language/hi Issues or PRs related to Hindi language label Oct 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign anubha-v-ardhan after the PR has been reviewed.
You can assign the PR to them by writing /assign @anubha-v-ardhan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 8, 2021
@indevi
Copy link
Author

indevi commented Oct 8, 2021

@anubha-v-ardhan This is my PR with no unnecessary commits

Copy link
Contributor

@AvineshTripathi AvineshTripathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a reviewer but going through the PR i felt like below line was not properly localised to hindi

for the line "हर एक से
प्रदाता पृष्ठ, आप सीख सकते हैं कि उत्पादन कैसे स्थापित करें और सेटअप करें
तैयार क्लस्टर।" can we change it to "हर एक प्रदाता पृष्ठ से आप सीख सकते हैं कि उत्पादन तैयार क्लस्टर को इंस्टॉल और सेटअप कैसे करे "

I didn't know how to do change in the commit itself so had to type it down sorry

Copy link
Member

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShivamTyagi12345 The file location is wrong. Can you fix it?

Comment on lines +8 to +10
यह पृष्ठ कुबेरनेट्स प्रमाणित समाधान प्रदाताओं की एक सूची प्रदान करता है। हर एक से
प्रदाता पृष्ठ, आप सीख सकते हैं कि उत्पादन कैसे स्थापित करें और सेटअप करें
तैयार क्लस्टर।
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change this to हर एक प्रदाता पृष्ठ से आप सीख सकते हैं कि उत्पादन योग्य क्लस्टर को इंस्टॉल और सेटअप कैसे करें। as recommended by @AvineshTripathi

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes sure .I will make the changes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShivamTyagi12345 Can you make the above suggested changes please.
Also, the file location is incorrect, Can you fix it :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please send the correct file location @anubha-v-ardhan

Copy link
Member

@anubha-v-ardhan anubha-v-ardhan Oct 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content/hi/docs/setup/production-environment/turnkey-solutions.md

@indevi indevi changed the title [hi] Add content\hi\docs\setup\production-environment\turnkey-solutions.md [hi] Add content/hi/docs/setup/production-environment/turnkey-solutions.md Oct 23, 2021
@indevi
Copy link
Author

indevi commented Oct 30, 2021

moved the pr to #30303 because i accidentally merged the main branch

@indevi indevi closed this Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/hi Issues or PRs related to Hindi language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants