Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hi] Add content/hi/docs/setup/best-practices/_index.md #29374

Merged
merged 3 commits into from
Oct 23, 2021
Merged

[hi] Add content/hi/docs/setup/best-practices/_index.md #29374

merged 3 commits into from
Oct 23, 2021

Conversation

anubha-v-ardhan
Copy link
Member

@anubha-v-ardhan anubha-v-ardhan commented Aug 13, 2021 •
edited
Loading

This PR is a part of ongoing hi localization effort here #29353

/language hi

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/hi Issues or PRs related to Hindi language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 13, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 13, 2021
@anubha-v-ardhan anubha-v-ardhan mentioned this pull request Aug 13, 2021
Closed
52 tasks
@netlify
Copy link

netlify bot commented Aug 13, 2021

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 078985f

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6116557364d22600078b8b87

😎 Browse the preview: https://deploy-preview-29374--kubernetes-io-main-staging.netlify.app

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 13, 2021
This was referenced Aug 17, 2021
Closed
Closed
@mittalyashu
Copy link
Member

/assign anubha-v-ardhan

@anubha-v-ardhan anubha-v-ardhan changed the base branch from main to dev-1.22-hi.1 September 12, 2021 11:06
@anubha-v-ardhan anubha-v-ardhan marked this pull request as ready for review September 15, 2021 03:28
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2021
@divya-mohan0209
Copy link
Contributor

/lgtm from my end. Althought, I really think प्रथाएं would be a better word to describe practices than प्रचलन.

@anubha-v-ardhan
Copy link
Member Author

/lgtm from my end. Althought, I really think प्रथाएं would be a better word to describe practices than प्रचलन.

+1,
changed it to प्रथाएं :)

@sftim
Copy link
Contributor

sftim commented Oct 21, 2021

#29374 (comment) plus 82a0c67 implies
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e3ca65c59cab96ebba569c2499f580a6423f80f8

@anubha-v-ardhan
Copy link
Member Author

anubha-v-ardhan commented Oct 23, 2021 •
edited
Loading

/approve
with respect to #29374 (comment) and #29374 (comment).

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anubha-v-ardhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1964dae into kubernetes:dev-1.22-hi.1 Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@mittalyashu mittalyashu mittalyashu left review comments

@daminisatya daminisatya Awaiting requested review from daminisatya

Assignees

@sftim sftim

@anubha-v-ardhan anubha-v-ardhan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/hi Issues or PRs related to Hindi language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anubha-v-ardhan @k8s-triage-robot @mittalyashu @divya-mohan0209 @sftim @k8s-ci-robot