Add documentation about `SeccompDefault` feature #27957

saschagrunert · 2021-05-12T11:21:15Z

This adds a documentation section about the SeccompDefault feature
gate for the kubelet. Beside that, the feature gate has been added to
the list of features, too.

Refers to kubernetes/enhancements#2413

Preview lazy link:
https://deploy-preview-27957--kubernetes-io-vnext-staging.netlify.app/docs/tutorials/clusters/seccomp

netlify · 2021-05-12T11:35:47Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d02e3b2

https://deploy-preview-27957--kubernetes-io-master-staging.netlify.app

netlify · 2021-05-12T11:40:53Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 52b0e46

https://deploy-preview-27957--kubernetes-io-master-staging.netlify.app

sftim

@saschagrunert Remember to target branch dev-1.22, not master

sftim

Given that this tutorial is going to be about trying an alpha feature, let's reword:

This tutorial will show examples with both alpha (pre-v1.19) and generally available seccomp functionality

and also:

let min-kubernetes-server-version: 1.22 in the page front matter
add a {{< version-check >}} shortcode to the prerequisites section, plus extra text about setting up kind to run a v1.22 or later cluster with the feature gate enabled.

content/en/docs/tutorials/clusters/seccomp.md

k8sio-netlify-preview-bot · 2021-05-12T11:57:07Z

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 27a74df

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/60d48467d049870008d171e2

saschagrunert · 2021-05-12T12:32:28Z

Thank you for the review @sftim 🙏 ! I hope I understood and addressed your comments correctly.

Superseded

sftim

Can we be sure that kind will provide a tool that deploys a v1.22 cluster on or soon after release day?

I notice latest kind deploys a v1.20 cluster.

saschagrunert · 2021-05-12T12:50:01Z

Can we be sure that kind will provide a tool that deploys a v1.22 cluster on or soon after release day?

I notice latest kind deploys a v1.20 cluster.

No, I assume that the images will be updated manually after a k8s release.

cc @BenTheElder

saschagrunert · 2021-06-24T09:23:00Z

Thank you for the review, I had to mention the --seccomp-default kubelet flag too and added a link to the KEP for referring to the upgrade and downgrade strategy.

content/en/docs/reference/command-line-tools-reference/feature-gates.md

content/en/docs/tutorials/clusters/seccomp.md

This adds a documentation section about the `SeccompDefault` feature gate for the kubelet. Beside that, the feature gate has been added to the list of features, too. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>

saschagrunert · 2021-06-24T13:12:18Z

Thank you for the review @tengqm, I added and fixed your suggestions :)

saschagrunert · 2021-06-24T21:15:25Z

k/k PR merged, this is now ready, too. A feature blog post with more background information is in progress, especially covering upgrade and downgrade strategies.

tengqm · 2021-06-25T00:07:41Z

/lgtm

k8s-ci-robot · 2021-06-25T00:07:48Z

LGTM label has been added.

Git tree hash: d58454a5d3d3e8786c65c0e4a449875ff59f5c5a

saschagrunert · 2021-06-25T07:16:59Z

@kubernetes/sig-docs-en-owners please take a look

carlisia · 2021-06-28T02:56:27Z

/lgtm

carlisia · 2021-06-28T02:57:04Z

/approve

carlisia · 2021-06-28T02:58:45Z

/approved

sftim · 2021-06-28T09:25:34Z

I'll let the docs release team for v1.22 make the call on approval here.

saschagrunert · 2021-06-28T12:03:56Z

I'll let the docs release team for v1.22 make the call on approval here.

Requesting approval from @PI-Victor @ashnehete @carlisia @chrisnegus @ritpanjw

PI-Victor · 2021-06-28T12:05:40Z

thank you for your work @saschagrunert!

/approve

ps: had this written but forgot to press the button.

k8s-ci-robot · 2021-06-28T12:05:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlisia, PI-Victor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [PI-Victor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

BenTheElder · 2021-08-04T22:58:48Z

#27957 (comment) FTR kind create cluster --image=kindest/node:v1.22.0@sha256:b8bda84bb3a190e6e028b1760d277454a72267a5454b57db34437c34a588d047 works with the current stable release (kind v0.11.1) that has been out for some time, I'll be adding that image to the list of available images for that release and we'll be cutting a new release that defaults to v1.22 in the near future.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 12, 2021

saschagrunert mentioned this pull request May 12, 2021

Kubelet option to enable seccomp by default kubernetes/enhancements#2413

Closed

12 tasks

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 12, 2021

k8s-ci-robot requested review from onlydole and pjbgf May 12, 2021 11:21

k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 12, 2021

saschagrunert force-pushed the seccomp-default branch 2 times, most recently from d129b8e to 52b0e46 Compare May 12, 2021 11:23

sftim previously requested changes May 12, 2021

View reviewed changes

saschagrunert changed the base branch from master to dev-1.22 May 12, 2021 11:55

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 12, 2021

sftim reviewed May 12, 2021

View reviewed changes

content/en/docs/tutorials/clusters/seccomp.md Outdated Show resolved Hide resolved

saschagrunert force-pushed the seccomp-default branch from 52b0e46 to 1e013a3 Compare May 12, 2021 11:57

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 12, 2021

saschagrunert force-pushed the seccomp-default branch 6 times, most recently from 4e0217b to e52639e Compare May 12, 2021 12:31

sftim reviewed May 12, 2021

View reviewed changes

saschagrunert force-pushed the seccomp-default branch 6 times, most recently from 3106eaf to 5746b63 Compare June 24, 2021 09:22

tengqm reviewed Jun 24, 2021

View reviewed changes

saschagrunert force-pushed the seccomp-default branch 2 times, most recently from 9738b6f to de98ba2 Compare June 24, 2021 13:10

Add documentation about SeccompDefault feature

27a74df

This adds a documentation section about the `SeccompDefault` feature gate for the kubelet. Beside that, the feature gate has been added to the list of features, too. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>

saschagrunert force-pushed the seccomp-default branch from de98ba2 to 27a74df Compare June 24, 2021 13:11

k8s-ci-robot assigned tengqm Jun 25, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2021

k8s-ci-robot merged commit 48c2535 into kubernetes:dev-1.22 Jun 28, 2021

saschagrunert deleted the seccomp-default branch June 28, 2021 12:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add documentation about `SeccompDefault` feature #27957

Add documentation about `SeccompDefault` feature #27957

saschagrunert commented May 12, 2021 •

edited

Loading

netlify bot commented May 12, 2021

netlify bot commented May 12, 2021

sftim left a comment

sftim left a comment

k8sio-netlify-preview-bot commented May 12, 2021 •

edited by netlify bot

Loading

saschagrunert commented May 12, 2021

sftim left a comment

saschagrunert commented May 12, 2021

saschagrunert commented Jun 24, 2021

saschagrunert commented Jun 24, 2021

saschagrunert commented Jun 24, 2021

tengqm commented Jun 25, 2021

k8s-ci-robot commented Jun 25, 2021

saschagrunert commented Jun 25, 2021

carlisia commented Jun 28, 2021

carlisia commented Jun 28, 2021

carlisia commented Jun 28, 2021

sftim commented Jun 28, 2021

saschagrunert commented Jun 28, 2021

PI-Victor commented Jun 28, 2021

k8s-ci-robot commented Jun 28, 2021

BenTheElder commented Aug 4, 2021

Add documentation about SeccompDefault feature #27957

Add documentation about SeccompDefault feature #27957

Conversation

saschagrunert commented May 12, 2021 • edited Loading

netlify bot commented May 12, 2021

netlify bot commented May 12, 2021

sftim left a comment

Choose a reason for hiding this comment

sftim left a comment

Choose a reason for hiding this comment

k8sio-netlify-preview-bot commented May 12, 2021 • edited by netlify bot Loading

saschagrunert commented May 12, 2021

sftim left a comment

Choose a reason for hiding this comment

saschagrunert commented May 12, 2021

saschagrunert commented Jun 24, 2021

saschagrunert commented Jun 24, 2021

saschagrunert commented Jun 24, 2021

tengqm commented Jun 25, 2021

k8s-ci-robot commented Jun 25, 2021

saschagrunert commented Jun 25, 2021

carlisia commented Jun 28, 2021

carlisia commented Jun 28, 2021

carlisia commented Jun 28, 2021

sftim commented Jun 28, 2021

saschagrunert commented Jun 28, 2021

PI-Victor commented Jun 28, 2021

k8s-ci-robot commented Jun 28, 2021

BenTheElder commented Aug 4, 2021

Add documentation about `SeccompDefault` feature #27957

Add documentation about `SeccompDefault` feature #27957

saschagrunert commented May 12, 2021 •

edited

Loading

k8sio-netlify-preview-bot commented May 12, 2021 •

edited by netlify bot

Loading