Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Updated daemonset for taints and tolerations. #2776

Closed
wants to merge 1 commit into from
Closed

WIP: Updated daemonset for taints and tolerations. #2776

wants to merge 1 commit into from

Conversation

gyliu513
Copy link
Contributor

@gyliu513 gyliu513 commented Mar 12, 2017 •
edited by k8s-reviewable
Loading

Fixed part of #2737

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 12, 2017
@gyliu513 gyliu513 mentioned this pull request Mar 12, 2017
Merged
cmluciano
cmluciano reviewed Mar 13, 2017
View reviewed changes
docs/admin/daemons.md
## How Daemon Pods work with taints and tolerations

Daemon pods will not be deleted by `NodeController` in case of node problems, such as when node turns to
`Unreachable` or `NotReady`. The reason is that the `NodeController` added an infinite tolerations of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence doesn't read well to me and it is quite long. Consider replacing "the reason" and rephrasing "added an infinite tolerations".

Toleration is a verb and should not include an "s".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Daemon pods/Daemonset pods

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/added/adds

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NodeController will not delete Daemonset pods in case of node problems, such as a node being Unreachable or NotReady, because the NodeController adds infinite toleration for Unreachable and NotReady taints.
??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Daemonset has its own controller and node controller just adds the taints.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all for the comments, I was planning to make this as a reference to #2774 as there is a section explaining daemonset logic there.

Marking this as WIP to wait #2774 to be merged first before I update this PR.

@aveshagarwal
Copy link
Member

FYI: @mburke5678

@gyliu513 gyliu513 changed the title Updated daemonset for taints and tolerations. WIP: Updated daemonset for taints and tolerations. Mar 13, 2017
@davidopp
Copy link
Member

I noticed another thing we need to change in that doc, so I just went ahead and made all of the changes in a new PR #2905 so I'm going to close this one.

@davidopp davidopp closed this Mar 18, 2017
@gyliu513 gyliu513 deleted the daemonset branch March 18, 2017 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aveshagarwal aveshagarwal aveshagarwal left review comments

@cmluciano cmluciano cmluciano left review comments

@mburke5678 mburke5678 mburke5678 left review comments

Assignees

@erictune erictune

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gyliu513 @aveshagarwal @davidopp @cmluciano @mburke5678 @erictune @k8s-ci-robot