Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix content/en/docs/concepts/storage/volumes.md #26646

Merged
merged 1 commit into from
Mar 14, 2021

Conversation

jailton
Copy link
Member

@jailton jailton commented Feb 20, 2021

Rewriting the description in the background section of how a volume behaves when a pod ceases to exist.

Fix: #26563

Preview: https://deploy-preview-26646--kubernetes-io-master-staging.netlify.app/docs/concepts/storage/volumes/

/language en

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 20, 2021
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2021
@jailton jailton changed the title Update content/en/docs/concepts/storage/volumes.md Fix content/en/docs/concepts/storage/volumes.md Feb 20, 2021
@netlify
Copy link

netlify bot commented Feb 20, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 3f63432

https://deploy-preview-26646--kubernetes-io-master-staging.netlify.app

@@ -34,8 +34,7 @@ Kubernetes supports many types of volumes. A {{< glossary_tooltip term_id="pod"
can use any number of volume types simultaneously.
Ephemeral volume types have a lifetime of a pod, but persistent volumes exist beyond
the lifetime of a pod. Consequently, a volume outlives any containers
that run within the pod, and data is preserved across container restarts. When a
pod ceases to exist, the volume is destroyed.
that run within the pod, and data is preserved across container restarts. When a pod ceases to exist, Kubernetes destroys ephemeral volumes; however, Kubernetes does not destroy persistent volumes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revision lgtm. Pls consider wrap the long lines appropriately.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@tengqm
Copy link
Contributor

tengqm commented Feb 21, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2021
@jailton jailton requested a review from tengqm February 21, 2021 06:47
@kbhawkey
Copy link
Contributor

/cc @kubernetes/sig-storage-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Feb 21, 2021
@kbhawkey
Copy link
Contributor

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 21, 2021
@kbhawkey
Copy link
Contributor

kbhawkey commented Mar 1, 2021

👋 @jailton . The changes look good. Thanks for contributing!
/cc @kubernetes/sig-storage-pr-reviews

Comment on lines 35 to +39
Ephemeral volume types have a lifetime of a pod, but persistent volumes exist beyond
the lifetime of a pod. Consequently, a volume outlives any containers
that run within the pod, and data is preserved across container restarts. When a
pod ceases to exist, the volume is destroyed.
that run within the pod, and data is preserved across container restarts. When a pod
ceases to exist, Kubernetes destroys ephemeral volumes; however, Kubernetes does not
destroy persistent volumes.
Copy link
Contributor

@shannonxtreme shannonxtreme Mar 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

Ephemeral volume types have the lifespan of a Pod. Persistent volume types exist past the lifespan of a Pod. As a result, volumes outlive containers running in the Pod, preserving data across container restarts. When the Pod ceases to exist, Kubernetes destroys ephemeral volumes, but does not destroy persistent volumes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jailton , Would you rebase your changes into a single commit? Thanks!
@shannonxtreme Thanks for the suggested edits. What do you think about opening a new PR with these changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

@shannonxtreme shannonxtreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up line 35-39 for more clarity.

… behaves when a pod ceases to exist.

Signed-off-by: Jailton Lopes <jailton@gmail.com>
@jailton jailton force-pushed the en/concepts/storage branch from d9611f4 to 3f63432 Compare March 14, 2021 02:03
@jailton jailton requested a review from kbhawkey March 14, 2021 02:06
@kbhawkey
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 95d0c2cbe9461b995a3ddf04a0118f44dc3d89bc

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit 885daa2 into kubernetes:master Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ephemeral vs. persistent volumes wording
5 participants