-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix content/en/docs/concepts/storage/volumes.md #26646
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit 3f63432 https://deploy-preview-26646--kubernetes-io-master-staging.netlify.app |
@@ -34,8 +34,7 @@ Kubernetes supports many types of volumes. A {{< glossary_tooltip term_id="pod" | |||
can use any number of volume types simultaneously. | |||
Ephemeral volume types have a lifetime of a pod, but persistent volumes exist beyond | |||
the lifetime of a pod. Consequently, a volume outlives any containers | |||
that run within the pod, and data is preserved across container restarts. When a | |||
pod ceases to exist, the volume is destroyed. | |||
that run within the pod, and data is preserved across container restarts. When a pod ceases to exist, Kubernetes destroys ephemeral volumes; however, Kubernetes does not destroy persistent volumes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revision lgtm. Pls consider wrap the long lines appropriately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @kubernetes/sig-storage-pr-reviews |
/kind cleanup |
👋 @jailton . The changes look good. Thanks for contributing! |
Ephemeral volume types have a lifetime of a pod, but persistent volumes exist beyond | ||
the lifetime of a pod. Consequently, a volume outlives any containers | ||
that run within the pod, and data is preserved across container restarts. When a | ||
pod ceases to exist, the volume is destroyed. | ||
that run within the pod, and data is preserved across container restarts. When a pod | ||
ceases to exist, Kubernetes destroys ephemeral volumes; however, Kubernetes does not | ||
destroy persistent volumes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
Ephemeral volume types have the lifespan of a Pod. Persistent volume types exist past the lifespan of a Pod. As a result, volumes outlive containers running in the Pod, preserving data across container restarts. When the Pod ceases to exist, Kubernetes destroys ephemeral volumes, but does not destroy persistent volumes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jailton , Would you rebase your changes into a single commit? Thanks!
@shannonxtreme Thanks for the suggested edits. What do you think about opening a new PR with these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean up line 35-39 for more clarity.
… behaves when a pod ceases to exist. Signed-off-by: Jailton Lopes <jailton@gmail.com>
d9611f4
to
3f63432
Compare
/lgtm |
LGTM label has been added. Git tree hash: 95d0c2cbe9461b995a3ddf04a0118f44dc3d89bc
|
Rewriting the description in the background section of how a volume behaves when a pod ceases to exist.
Fix: #26563
Preview: https://deploy-preview-26646--kubernetes-io-master-staging.netlify.app/docs/concepts/storage/volumes/
/language en