Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update diagram docs/tutorials/kubernetes-basics/public/images/module_01_cluster.svg #26644

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

jailton
Copy link
Member

@jailton jailton commented Feb 20, 2021

Update diagram docs/tutorials/kubernetes-basics/public/images/module_01_cluster.svg to to use the "control plane" terminology.

Fix: #26640
Ref: #21621

Preview: https://d33wubrfki0l68.cloudfront.net/283cc20bb49089cb2ca54d51b4ac27720c1a7902/34424/docs/tutorials/kubernetes-basics/public/images/module_01_cluster.svg

/language en

…er.svg to to use the "control plane" terminology

Signed-off-by: Jailton Lopes <jailton@gmail.com>
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 20, 2021
@k8s-ci-robot k8s-ci-robot requested review from sftim and tengqm February 20, 2021 19:06
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 20, 2021
@netlify
Copy link

netlify bot commented Feb 20, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit f381ec8

https://deploy-preview-26644--kubernetes-io-master-staging.netlify.app

@tengqm
Copy link
Contributor

tengqm commented Feb 21, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9aca96c2312e2a5b0745208d79e8b9710c233d2a

@sftim
Copy link
Contributor

sftim commented Feb 21, 2021

@jailton, we need to fix the text at the same time as the diagram.

If you look at https://deploy-preview-26644--kubernetes-io-master-staging.netlify.app/docs/tutorials/kubernetes-basics/create-cluster/cluster-intro/ you'll see the diagram mentions a “control plane” but the page text refers to a “Master”.

You can:

  • open another PR to fix the page text, and we can octopus-merge that along with this one
    (fiddly, but possible)
  • revise this PR to also reword the page text
    (easier)

Would you be willing to do one out of those choices?

/hold
for now

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2021
@jailton
Copy link
Member Author

jailton commented Feb 21, 2021

@sftim, I've already corrected the text in PR #26645.

@celestehorgan
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celestehorgan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2021
@sftim
Copy link
Contributor

sftim commented Feb 24, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit 20f9d28 into kubernetes:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use “control plane” terminology in Use minikube to Create a Cluster
5 participants