Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

es: clean up capture stmts in Secret concept page #26428

Merged
merged 1 commit into from
Feb 15, 2021
Merged

es: clean up capture stmts in Secret concept page #26428

merged 1 commit into from
Feb 15, 2021

Conversation

kbhawkey
Copy link
Contributor

@kbhawkey kbhawkey commented Feb 8, 2021

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 8, 2021
@kbhawkey
Copy link
Contributor Author

kbhawkey commented Feb 8, 2021

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/es Issues or PRs related to Spanish language labels Feb 8, 2021
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 8, 2021
@kbhawkey
Copy link
Contributor Author

kbhawkey commented Feb 8, 2021

/cc @kubernetes/sig-docs-es-reviews

@netlify
Copy link

netlify bot commented Feb 8, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 90d92ba

https://deploy-preview-26428--kubernetes-io-master-staging.netlify.app

@electrocucaracha
Copy link
Contributor

/lgtm , BTW it seems like the translated document needs some sync

irvifa
irvifa reviewed Feb 8, 2021
View reviewed changes
Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9c8a48883f8fa7c3eeb2a0a7f103d8e1629c45d1

@irvifa
Copy link
Member

irvifa commented Feb 8, 2021

@electrocucaracha It seems so, but I wonder if this can be in another PR since the intent of this PR is for clean up purposes

@kbhawkey
Copy link
Contributor Author

kbhawkey commented Feb 9, 2021

Hi @electrocucaracha .
If you'd rather clean up the capture statements with other es changes, I can close this PR?
Page preview:
https://deploy-preview-26428--kubernetes-io-master-staging.netlify.app/es/docs/concepts/configuration/secret/

@electrocucaracha
Copy link
Contributor

@kbhawkey I'm okay with these changes but I need someone else to approve them

/cc @raelga

@raelga
Copy link
Member

raelga commented Feb 15, 2021

Thanks for the fix!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raelga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0dead1b into kubernetes:master Feb 15, 2021
@kbhawkey kbhawkey deleted the clean-es-markup branch June 23, 2021 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irvifa irvifa irvifa left review comments

@alexbrand alexbrand Awaiting requested review from alexbrand

@raelga raelga Awaiting requested review from raelga

Assignees

@irvifa irvifa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/es Issues or PRs related to Spanish language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kbhawkey @electrocucaracha @k8s-ci-robot @irvifa @raelga