Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #26207

Merged
merged 2 commits into from
Feb 6, 2021
Merged

Update README.md #26207

merged 2 commits into from
Feb 6, 2021

Conversation

jailton
Copy link
Member

@jailton jailton commented Jan 23, 2021

Add instruction to access API reference pages URL locally

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2021
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 23, 2021
@netlify
Copy link

netlify bot commented Jan 23, 2021 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit b84e52e

https://deploy-preview-26207--kubernetes-io-master-staging.netlify.app

Arhell
Arhell reviewed Jan 23, 2021
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/language en

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 23, 2021
@bradtopol
Copy link
Contributor

This looks like one for @jimangel.
/assign @jimangel

celestehorgan
celestehorgan suggested changes Feb 1, 2021
View reviewed changes
@jailton @celestehorgan
Update README.md
b84e52e 
Co-authored-by: Celeste Horgan <celeste@cncf.io>
@celestehorgan
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f411e2fcebfaf74f4486a9b622f3c4563dcdc844

irvifa
irvifa reviewed Feb 6, 2021
View reviewed changes
Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit fb8b89d into kubernetes:master Feb 6, 2021
@jailton jailton deleted the en/update-readme-20210122 branch February 20, 2021 19:36
@jailton jailton mentioned this pull request Feb 24, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irvifa irvifa irvifa left review comments

@Arhell Arhell Arhell left review comments

@celestehorgan celestehorgan celestehorgan requested changes

@rajeshdeshpande02 rajeshdeshpande02 Awaiting requested review from rajeshdeshpande02

Assignees

@jimangel jimangel

@celestehorgan celestehorgan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jailton @bradtopol @celestehorgan @k8s-ci-robot @irvifa @Arhell @jimangel