Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh] Clean PodPreset related pages/examples #26133

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Jan 18, 2021

This PR drops the contents related to PodPreset in zh localization. Wherever a resync of the page needed, a resync is performed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 18, 2021
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 18, 2021
@netlify
Copy link

netlify bot commented Jan 18, 2021

✔️ Deploy preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: b9265d3

🔍 Inspect the deploy logs: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/600578cc70d16e0007e71f87

😎 Browse the preview: https://deploy-preview-26133--kubernetes-io-master-staging.netlify.app

@howieyuen
Copy link
Member

just curious, how do you know the wherever? I wanna learn~

@tengqm
Copy link
Contributor Author

tengqm commented Jan 19, 2021

@howieyuen There is a util script under /scripts. ./scripts/lsync.sh content/zh/<path> generates a summary of pages that are out of sync. ./scripts/lsync.sh content/zh/<path>/<file>.md generates a diff of the upstream changes that are not synced to zh localization. These all assume we are strictly following the "no-partial-patch" policy.

@howieyuen
Copy link
Member

@howieyuen There is a util script under /scripts. ./scripts/lsync.sh content/zh/<path> generates a summary of pages that are out of sync. ./scripts/lsync.sh content/zh/<path>/<file>.md generates a diff of the upstream changes that are not synced to zh localization. These all assume we are strictly following the "no-partial-patch" policy.

so it is, I have always followed the scripts summary to make sure whether zh doc is out of sync.

@howieyuen
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6422edcda9ddc988ef849f8d1db2e67698b1255b

Copy link
Member

@tanjunchen tanjunchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2021
Copy link
Member

@tanjunchen tanjunchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 58f2248 into kubernetes:master Jan 19, 2021
@tengqm tengqm deleted the zh-resync-podpreset branch January 20, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants