Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TokenRequest and TokenRequestProjection are GA now #24823

Merged
merged 1 commit into from
Nov 4, 2020
Merged

TokenRequest and TokenRequestProjection are GA now #24823

merged 1 commit into from
Nov 4, 2020

Conversation

zshihang
Copy link
Contributor

TokenRequest and TokenRequestProjection are GA now

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 30, 2020
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Oct 30, 2020 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 0d0cc43

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5fa2e7be3af09400072dcba0

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 30, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 30, 2020
@zshihang
Copy link
Contributor Author

/cc @liggitt

@liggitt
Copy link
Member

liggitt commented Oct 30, 2020

/lgtm
/hold for kubernetes/kubernetes#93258

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 17311838a94c083eecc328261ea389e23b4f1041

@annajung
Copy link
Contributor

/milestone 1.20

@k8s-ci-robot k8s-ci-robot added this to the 1.20 milestone Oct 30, 2020
sftim
sftim requested changes Oct 31, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zshihang

I've added some advice about making these changes match how SIG Docs normally does them.

content/en/docs/tasks/configure-pod-container/configure-service-account.md Outdated
Comment on lines 292 to 298
This TokenRequest and TokenRequestProjection are __GA__ in 1.20 and
enabled by passing all of the following flags to the API server:

* `--service-account-issuer`
* `--service-account-key-file`
* `--service-account-signing-key-file`
* `--service-account-api-audiences`
* `--api-audiences`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GA features are enabled by default. We can omit the note.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The api server requires these options be set if the functionality is desired. What is a better way to phrase this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested text added.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2020
@kikisdeliveryservice
Copy link
Member

As noted on this PR (kubernetes/kubernetes#93258 (comment)) the release team has no Enhancement 1205 on record as being GA for this release. Please clarify/file and exception request as necessary.

@annajung
Copy link
Contributor

annajung commented Nov 2, 2020

/hold until #24823 (comment) is resolved

@zshihang
Copy link
Contributor Author

zshihang commented Nov 2, 2020

exception issue is opened kubernetes/enhancements#2126

@liggitt liggitt mentioned this pull request Nov 2, 2020
Closed
tengqm
tengqm reviewed Nov 3, 2020
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md
@@ -303,6 +303,8 @@ different Kubernetes components.
| `TaintNodesByCondition` | `false` | Alpha | 1.8 | 1.11 |
| `TaintNodesByCondition` | `true` | Beta | 1.12 | 1.16 |
| `TaintNodesByCondition` | `true` | GA | 1.17 | - |
| `TokenRequest` | `true` | GA | 1.20 | - |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do NOT remove the history.
Line 155-158 should be moved here.
The goal is to let users see the evolution history of the feature, not just its current state.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. the history was not removed but kept in the last section.

@liggitt liggitt mentioned this pull request Nov 3, 2020
Closed
@annajung
Copy link
Contributor

annajung commented Nov 3, 2020

/hold cancel
exception approved, k/k pr merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2020
@liggitt
Copy link
Member

liggitt commented Nov 3, 2020

/hold

would like to keep this on hold until KEP updates are made

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2020
@zshihang
Copy link
Contributor Author

zshihang commented Nov 4, 2020

KEP updates merged. https://github.com/kubernetes/enhancements/blob/master/keps/sig-auth/1205-bound-service-account-tokens/README.md

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2020
@liggitt
Copy link
Member

liggitt commented Nov 4, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 67a901f493b347db4fce21b68da0010f9a3b0464

@irvifa
Copy link
Member

irvifa commented Nov 4, 2020

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 4, 2020
irvifa
irvifa reviewed Nov 4, 2020
View reviewed changes
Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3590d73 into kubernetes:dev-1.20 Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim requested changes

@irvifa irvifa irvifa left review comments

@tengqm tengqm tengqm left review comments

@liggitt liggitt Awaiting requested review from liggitt

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
1.20
Development

Successfully merging this pull request may close these issues.
9 participants
@zshihang @k8sio-netlify-preview-bot @liggitt @k8s-ci-robot @annajung @kikisdeliveryservice @irvifa @tengqm @sftim