Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the issue #20445 #21963

Merged
merged 2 commits into from
Jun 29, 2020
Merged

fix the issue #20445 #21963

merged 2 commits into from
Jun 29, 2020

Conversation

TomorJM
Copy link
Contributor

@TomorJM TomorJM commented Jun 21, 2020

translate into Chinese

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 21, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 21, 2020
@TomorJM
Copy link
Contributor Author

TomorJM commented Jun 21, 2020

/assign tengqm

@TomorJM
Copy link
Contributor Author

TomorJM commented Jun 21, 2020

#20445

@netlify
Copy link

netlify bot commented Jun 21, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 2d31450

https://deploy-preview-21963--kubernetes-io-master-staging.netlify.app

@tengqm
Copy link
Contributor

tengqm commented Jun 22, 2020

@TomorJM Thanks for the contribution.
As a convention, we preserve existing English contents in comments rather than replace them. The intent is to make it possible to track changes to the upstream English text. So .. instead of replacing <h1>hello</h1> by <h1>你好</h1>, we do this:

  <!-- h1>hello</h1 -->
  <h1>你好</h1>

@TomorJM
Copy link
Contributor Author

TomorJM commented Jun 22, 2020

@TomorJM Thanks for the contribution.
As a convention, we preserve existing English contents in comments rather than replace them. The intent is to make it possible to track changes to the upstream English text. So .. instead of replacing <h1>hello</h1> by <h1>你好</h1>, we do this:

  <!-- h1>hello</h1 -->
  <h1>你好</h1>

Get it, I will supplement the missing lines and reload this PR

@TomorJM
Copy link
Contributor Author

TomorJM commented Jun 22, 2020

@TomorJM Thanks for the contribution.
As a convention, we preserve existing English contents in comments rather than replace them. The intent is to make it possible to track changes to the upstream English text. So .. instead of replacing <h1>hello</h1> by <h1>你好</h1>, we do this:

  <!-- h1>hello</h1 -->
  <h1>你好</h1>

@TomorJM Thanks for the contribution.
As a convention, we preserve existing English contents in comments rather than replace them. The intent is to make it possible to track changes to the upstream English text. So .. instead of replacing <h1>hello</h1> by <h1>你好</h1>, we do this:

  <!-- h1>hello</h1 -->
  <h1>你好</h1>

Get it, I will supplement the missing lines and reload this PR

Done

@@ -1,5 +1,6 @@
---
title: Using a Service to Expose Your App
<!--title: Using a Service to Expose Your App-->
title: 使用 Service 暴露您的应用
weight: 10
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 1-5 above is the "front-matter" for a content page. Please treat it as a single unit rather than insert comments into it. It may prove to work after all. Just want to be cautious at structuring things. A better option:

---
title: 中文翻译
weight: 10
---
<!--
title: english title
weight: 10
-->

Note that the front-matter must appear before the comment lines just so that the parser won't break accidentally.

<!-- <li>Understand how labels and LabelSelector objects relate to a Service</li>-->
<!-- <li>Expose an application outside a Kubernetes cluster using a Service</li>-->
<li>了解 Kubernetes 中的 Service </li>
<li>了解 标签(Label) 和 标签选择器(Label Selector) 对象如何与 Service 关联</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

译成中文时,请尽量注意:

  • 中文和英文(含数字)之间至少留一个空格;
  • 尽量使用中文全角标点符号

<!-- <li>Expose an application outside a Kubernetes cluster using a Service</li>-->
<li>了解 Kubernetes 中的 Service </li>
<li>了解 标签(Label) 和 标签选择器(Label Selector) 对象如何与 Service 关联</li>
<li>在 Kubernetes 集群外用 Service 暴露应用</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li>在 Kubernetes 集群外用 Service 暴露应用</li>
<li>用 Service 将应用暴露到 Kubernetes 集群之外</li>

@tengqm
Copy link
Contributor

tengqm commented Jun 22, 2020

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2020
@zhangxiaoyu-zidif
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhangxiaoyu-zidif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0a13293 into kubernetes:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants