Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove note from Job concept about Pod backoff failure policy #21950

Merged
merged 1 commit into from
Jun 21, 2020
Merged

Remove note from Job concept about Pod backoff failure policy #21950

merged 1 commit into from
Jun 21, 2020

Conversation

Cweiping
Copy link

fix Page:
https://kubernetes.io/docs/concepts/workloads/controllers/job/#pod-backoff-failure-policy

Tips for abandonment：

Note: Issue #54870 still exists for versions of Kubernetes prior to version 1.12

Issue #54870 has been fixed, and I didn't reproduce the problem in v1.18.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 21, 2020
@netlify
Copy link

netlify bot commented Jun 21, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 03092ee

https://deploy-preview-21950--kubernetes-io-master-staging.netlify.app

remove unnecessary note
03092ee 
Signed-off-by: Weiping Cai <weiping.cai@daocloud.io>
@Cweiping Cweiping force-pushed the remove_unnecessary_note branch from 68922a3 to 03092ee Compare June 21, 2020 05:57
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2020
@sftim
Copy link
Contributor

sftim commented Jun 21, 2020

@Cweiping to avoid problems with issues in PR titles, I'm going to:
/retitle Remove note from Job concept about Pod backoff failure policy

@k8s-ci-robot k8s-ci-robot changed the title remove unnecessary note, issue # 54870 already fixed Remove note from Job concept about Pod backoff failure policy Jun 21, 2020
sftim
sftim reviewed Jun 21, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit 01124bf into kubernetes:master Jun 21, 2020
@Cweiping
Copy link
Author

@Cweiping to avoid problems with issues in PR titles, I'm going to:
/retitle Remove note from Job concept about Pod backoff failure policy

ok,I get it.Thx!

@Cweiping Cweiping deleted the remove_unnecessary_note branch June 22, 2020 03:51
@Cweiping Cweiping mentioned this pull request Nov 9, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@kbarnard10 kbarnard10 Awaiting requested review from kbarnard10

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cweiping @sftim @k8s-ci-robot