-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct wordpress service command output #21946
Conversation
per the instructions, the wordpress service is a LoadBalancer.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @lukewendling! |
CLA check |
CLA check 2 |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 966215f https://deploy-preview-21946--kubernetes-io-master-staging.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the change. I wonder if there's also a case for updating the note that follows?
/lgtm
/approve
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE | ||
wordpress ClusterIP 10.0.0.89 <pending> 80:32406/TCP 4m | ||
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE | ||
wordpress LoadBalancer 10.0.0.89 <pending> 80:32406/TCP 4m | ||
``` | ||
|
||
{{< note >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukewendling, does this note also need to change?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
per the instructions, the wordpress service is a LoadBalancer.