Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in start contributing #12906

Merged
merged 1 commit into from
Mar 1, 2019
Merged

fix typo in start contributing #12906

merged 1 commit into from
Mar 1, 2019

Conversation

kbhawkey
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 28, 2019
@netlify
Copy link

netlify bot commented Feb 28, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 91f2753

https://deploy-preview-12906--kubernetes-io-master-staging.netlify.com

@kbhawkey
Copy link
Contributor Author

Preview page:
https://deploy-preview-12906--kubernetes-io-master-staging.netlify.com/docs/contribute/start/

DanyC97
DanyC97 approved these changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@DanyC97 DanyC97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was indeed my typo, thank you for catching it

@DanyC97
Copy link
Contributor

DanyC97 commented Feb 28, 2019

unfortunately i don't have permission for +1
maybe @zparnold can help ?

@Rajakavitha1
Copy link
Contributor

Thanks for the fix @kbhawkey . Checked the updates on : https://deploy-preview-12906--kubernetes-io-master-staging.netlify.com/docs/contribute/start/

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rajakavitha1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit 71662ad into kubernetes:master Mar 1, 2019
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
@kbhawkey
fix typo in start contributing (kubernetes#12906)
b87cb24
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@kbhawkey @yagonobre
fix typo in start contributing (kubernetes#12906)
7e70e57
@kbhawkey kbhawkey deleted the typo-contributor-guide branch October 9, 2019 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanyC97 DanyC97 DanyC97 approved these changes

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@Rajakavitha1 Rajakavitha1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kbhawkey @DanyC97 @Rajakavitha1 @k8s-ci-robot