Updating docs around default ImagePullPolicy #10284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to clear up a bit of the wording around an image's tag and how that impacts the ImagePullPolicy. The wording to me presently suggests *all* you need to do is use `:latest` as an image tag and that will change the `ImagePullPolicy` to latest. This is not the case that I've observed. As it stands now, `:latest` only affect the `ImagePullPolicy` if that attribute is not present on the pod's specification. https://github.com/kubernetes/kubernetes/blob/7f23a743e8c23ac6489340bbb34fa6f1d392db9d/pkg/apis/core/v1/defaults.go#L78 https://github.com/kubernetes/kubernetes/blob/7f23a743e8c23ac6489340bbb34fa6f1d392db9d/pkg/kubelet/images/image_manager_test.go#L63
k8s-ci-robot
added
cncf-cla: yes
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 760bf43 https://deploy-preview-10284--kubernetes-io-master-staging.netlify.com |
Bradamant3
suggested changes
Sep 20, 2018
|
/assign |
- Thanks for the super valuable feedback @Bradamant3. It reads a *lot* better now!
k8s-ci-robot
added
size/M
|
Thanks for the super valuable feedback @Bradamant3. It reads much cleaner now! |
Bradamant3
approved these changes
Sep 21, 2018
|
YOLO. We probably should ask for tech review, but ... /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bradamant3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to clear up a bit of the wording around an image's tag and how that impacts the ImagePullPolicy. The wording to me presently suggests all you need to do is use
:latestas an image tag and that will change theImagePullPolicyto latest.This is not the case that I've observed. As it stands now,
:latestonly affect theImagePullPolicyif that attribute is not present on the pod's specification. It is a bit "wordy" but there are some edge cases that are a bit difficult to explain.Any suggestions on how to improve this structure but cover them would be appreciated.
Reference to the appropriate code/test that handle the underlying default logic I found were:
https://github.com/kubernetes/kubernetes/blob/7f23a743e8c23ac6489340bbb34fa6f1d392db9d/pkg/apis/core/v1/defaults.go#L78
https://github.com/kubernetes/kubernetes/blob/7f23a743e8c23ac6489340bbb34fa6f1d392db9d/pkg/kubelet/images/image_manager_test.go#L63