Fixes from #10278 #10280
Fixes from #10278 #10280
Conversation
k8s-ci-robot
added
the
size/S
k8s-ci-robot
added
the
cncf-cla: yes
|
@zparnold As none of these changes are particularly pressing, feel free to change this PR's base to |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 457f464 https://deploy-preview-10280--kubernetes-io-master-staging.netlify.com |
| @@ -107,7 +107,7 @@ this example. | |||
|
|
|||
| If you already have a CA then the only action that is copying the CA's `crt` and | |||
| `key` file to `/etc/kubernetes/pki/etcd/ca.crt` and | |||
| `/etc/kubernetes/pki/etcd/ca.key`. After those files have been copied, please | |||
| `/etc/kubernetes/pki/etcd/ca.key`. After those files have been copied, | |||
| proceed to "Create certificates for each member". | |||
There was a problem hiding this comment.
One more, link to this step instead of quoting the title.
There was a problem hiding this comment.
Because it's a step and not a header, we'd have to create an anchor in order to link to it. That seems excessive, and like a path to reduced readability. Instead, I'd suggest:
proceed to the next step ("Create certificates for each member").
UPDATE: Even better:
proceed to the next step, "Create certificates for each member".
WDYT?
There was a problem hiding this comment.
Sure, or just "continue to the next step"? If it is literally the next step, that seems adequate.
content/en/docs/setup/scratch.md
Outdated
| @@ -419,7 +419,7 @@ Note that on some Linux platforms, you may need to manually install the | |||
| `conntrack` package which is a dependency of kube-proxy, or else kube-proxy | |||
| cannot be started successfully. | |||
|
|
|||
| For more details on debugging kube-proxy problems, please refer to | |||
| For more details on debugging kube-proxy problems, refer to | |||
Feedback from mistyhacks Update configure-upgrade-etcd.md Update configure-upgrade-etcd.md
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zparnold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This PR:
masterbased on review feedback on Incremental update from master #10278release-1.12/assign @zparnold @MistyHacks