Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump version of event-exporter #10191

Merged
merged 1 commit into from
Oct 4, 2018
Merged

bump version of event-exporter #10191

merged 1 commit into from
Oct 4, 2018

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Sep 5, 2018

upgrade version of event-exporter in the example.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 5, 2018
@ameukam
Copy link
Member Author

ameukam commented Sep 5, 2018

merge when kubernetes/kubernetes#67691 will be merged.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 6172004

https://deploy-preview-10191--kubernetes-io-master-staging.netlify.com

@ameukam
Copy link
Member Author

ameukam commented Sep 5, 2018

/assign @tengqm

@ameukam
Copy link
Member Author

ameukam commented Sep 10, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2018
@tengqm
Copy link
Contributor

tengqm commented Sep 10, 2018

@ameukam, please help check if this is supposed to go to releases-1.12 branch rather than master. 'master' here in website means 'release-1.11'.

@ameukam
Copy link
Member Author

ameukam commented Sep 21, 2018

@tengqm i will tag it for the 1.12 release.

@ameukam
Copy link
Member Author

ameukam commented Sep 21, 2018

/milestone v1.12

1 similar comment
@ameukam
Copy link
Member Author

ameukam commented Sep 26, 2018

/milestone v1.12

@zparnold
Copy link
Member

zparnold commented Oct 4, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2018
@kubernetes-docs-i18n-bot kubernetes-docs-i18n-bot added the language/en Issues or PRs related to English language label Oct 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2018
@k8s-ci-robot k8s-ci-robot merged commit 1be2a77 into kubernetes:master Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

Assignees

@tengqm tengqm

@zparnold zparnold

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ameukam @k8sio-netlify-preview-bot @tengqm @zparnold @k8s-ci-robot @kubernetes-docs-i18n-bot