-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.*: add presubmit check for verifying go directive changes #306
.*: add presubmit check for verifying go directive changes #306
Conversation
@MadhavJivrajani: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c8e6334
to
95d906a
Compare
Successful run in the normal case: https://github.com/kubernetes/utils/actions/runs/8169957204/job/22335081807?pr=306 |
95d906a
to
b716d8f
Compare
This commit adds a script that checks the changed version in the go.mod file with a certain maximum version that the go directive can have. We set the maximum version of the go directive as 1.20 here because the oldest go directive that exists on our supported release branches in k/k is 1.20. This commit additionally changes the requisite GH action to incorporate this check. Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
b716d8f
to
b01eb69
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, MadhavJivrajani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit adds a script that checks the changed version in the go.mod file with a certain maximum version that the go directive can have.
We set the maximum version of the go directive as 1.20 here because the oldest go directive that exists on our supported release branches in k/k is 1.20.
This commit additionally changes the requisite GH action to incorporate this check.
Fixes #305
xref kubernetes/kubernetes#123744
/sig architecture
/area code-organization
/kind cleanup
/assign @dims @liggitt