Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track DNS pod resource usage in scalability tests #9445

Merged
merged 3 commits into from
Oct 9, 2018

Conversation

chrisohaver
Copy link
Contributor

@chrisohaver chrisohaver commented Sep 17, 2018

Track resource usage of DNS pods during 2k and 5k node scalability tests.
Related: kubernetes/kubernetes#68613
Requires kubernetes/kubernetes#68683

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 17, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config labels Sep 17, 2018
@rajansandeep
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 17, 2018
@wojtek-t
Copy link
Member

wojtek-t commented Oct 1, 2018

This requires a PR in k/k. Once that one exists and is merged, I will lgtm it.

@wojtek-t wojtek-t self-assigned this Oct 1, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 1, 2018
@AishSundar
Copy link
Contributor

@wojtek-t were you holding your LGTM for kubernetes/kubernetes#69283 to merge into k/k? if so thats merged now. What else is pending? if not can we get this one merged as well?

@wojtek-t
Copy link
Member

wojtek-t commented Oct 5, 2018

@wojtek-t were you holding your LGTM for kubernetes/kubernetes#69283 to merge into k/k? if so thats merged now. What else is pending? if not can we get this one merged as well?

I don't want to merge this on Friday if it cause some issues, would like to be able to revert quickly.
Will merge on Monday.

@fturib
Copy link
Contributor

fturib commented Oct 8, 2018

@wojtek-t : would it be ok now to merge it ?

@wojtek-t
Copy link
Member

wojtek-t commented Oct 9, 2018

Yes, sorry - forgot yesterday.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2018
@fturib
Copy link
Contributor

fturib commented Oct 9, 2018

Looks like we need another approver here ....
/assign @krzyzacy - can you review and approve if ok ? thanks for help to get this merged.

@krzyzacy
Copy link
Member

krzyzacy commented Oct 9, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisohaver, krzyzacy, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2018
@k8s-ci-robot k8s-ci-robot merged commit f0b76c1 into kubernetes:master Oct 9, 2018
@k8s-ci-robot
Copy link
Contributor

@chrisohaver: Updated the job-config configmap using the following files:

  • key generated-security-jobs.yaml using file config/jobs/kubernetes-security/generated-security-jobs.yaml
  • key sig-scalability-periodic-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-periodic-jobs.yaml
  • key sig-scalability-presubmit-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-presubmit-jobs.yaml

In response to this:

Track resource usage of DNS pods during 2k and 5k node scalability tests.
Related: kubernetes/kubernetes#68613
Requires kubernetes/kubernetes#68683
Requires: kubernetes/kubernetes#69283

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SEJeff
Copy link

SEJeff commented Oct 29, 2018

@chrisohaver kubernetes/kubernetes#69283 has been merged FYI. Might want to update the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants