Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

milestone issue information moving #8902

Closed
wants to merge 1 commit into from
Closed

milestone issue information moving #8902

wants to merge 1 commit into from

Conversation

tpepper
Copy link
Member

@tpepper tpepper commented Jul 31, 2018

The documentation on how a developer gets code into a milestone release
is proposed to move in kubernetes/community#2430
and would require an associated update of the url the milestone munger
uses as a reference in its information GitHub comments.

Signed-off-by: Tim Pepper tpepper@vmware.com

milestone issue information moving
87370b7 
The documentation on how a developer gets code into a milestone release
is proposed to move in kubernetes/community#2430
and would require an associated update of the url the milestone munger
uses as a reference in its information GitHub comments.

Signed-off-by: Tim Pepper <tpepper@vmware.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 31, 2018
@tpepper
Copy link
Member Author

tpepper commented Jul 31, 2018

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 31, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tpepper
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: lavalamp

If they are not already assigned, you can assign the PR to them by writing /assign @lavalamp in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member

/assign @spiffxp

@spiffxp
Copy link
Member

spiffxp commented Aug 1, 2018

Since we've decided to disable the milestone-maintainer munger (kubernetes/sig-release#243 (comment)) I think this can be closed, but I'll hold off doing so until #8909 is deployed

@spiffxp
Copy link
Member

spiffxp commented Aug 4, 2018

/close
#8909 was deployed this morning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apelisse apelisse Awaiting requested review from apelisse

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@spiffxp spiffxp

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tpepper @k8s-ci-robot @BenTheElder @spiffxp