Removal of KubeletConfigFile feature gate: Step 2 (stop setting KubeletConfigFile) #6490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature gate is now a noop, and is no longer necessary to set. See: kubernetes/kubernetes#58760
k8s-ci-robot
added
the
size/M
k8s-ci-robot
added
the
cncf-cla: yes
mtaufen
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krzyzacy, mtaufen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
approved
mtaufen
added a commit
to mtaufen/kubernetes
that referenced
this pull request
Jan 29, 2018
This PR completes the work started in kubernetes#58760 by completely removing the KubeletConfigFile feature gate. We stopped setting the gate in test-infra in kubernetes/test-infra#6490.
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Jan 29, 2018
Automatic merge from submit-queue (batch tested with PRs 58777, 58978, 58977, 58775). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Removal of KubeletConfigFile feature gate: Step 3 (final) This PR completes the work started in #58760 by completely removing the KubeletConfigFile feature gate. We stopped setting the gate in test-infra in kubernetes/test-infra#6490. ```release-note The alpha KubeletConfigFile feature gate has been removed, because it was redundant with the Kubelet's --config flag. It is no longer necessary to set this gate to use the flag. The --config flag is still considered alpha. ```
iwankgb
pushed a commit
to iwankgb/kubernetes
that referenced
this pull request
Feb 15, 2018
This PR completes the work started in kubernetes#58760 by completely removing the KubeletConfigFile feature gate. We stopped setting the gate in test-infra in kubernetes/test-infra#6490.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature gate is now a noop, and is no longer necessary to set to use the generated Kubelet config file.
See: kubernetes/kubernetes#58760