Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress NGINX: Migrate to AR. #34301

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Ingress NGINX: Migrate to AR. #34301

merged 1 commit into from
Feb 10, 2025

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Feb 8, 2025

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 8, 2025
@Gacko
Copy link
Member Author

Gacko commented Feb 8, 2025

Copy link
Member

@strongjz strongjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2025
@ameukam
Copy link
Member

ameukam commented Feb 10, 2025

/approve
/hold

Remove the hold when ready.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, Gacko, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2025
@Gacko
Copy link
Member Author

Gacko commented Feb 10, 2025

/unhold

Thank you! Now I can test my changes in the Ingress NGINX repo! 😊

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 29396c7 into kubernetes:master Feb 10, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@Gacko: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8s-staging-ingress-nginx.yaml using file config/jobs/image-pushing/k8s-staging-ingress-nginx.yaml

In response to this:

Towards kubernetes/ingress-nginx#12400.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants