Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempted fix for pull-kubernetes-e2e-gce-network-policies #33468

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Attempted fix for pull-kubernetes-e2e-gce-network-policies #33468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/jobs/kubernetes/sig-network/sig-network-misc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ presubmits:
# Skipping snat tests probably GCE related? https://github.com/kubernetes/test-infra/issues/20321
# Skipping Cloud Provider specific tests: LoadBalancer, ESIPP (Source IP Preservation)
- >
--test_args=--ginkgo.skip=GCE|Disruptive|Serial|SNAT --ginkgo.label-filter='(sig-network || Conformance || Feature: containsAny {NetworkPolicy, NetworkPolicyEndPort} ) && !Feature: containsAny {Alpha, Beta, Example, Federation, IPv6DualStack, LoadBalancer, Networking-IPv6, PerformanceDNS, SCTPConnectivity, KubeProxyDaemonSetMigration}'
--test_args=--ginkgo.skip=GCE|Disruptive|Serial|SNAT --ginkgo.label-filter=(sig-network || Conformance || Feature: containsAny {NetworkPolicy, NetworkPolicyEndPort} ) && !Feature: containsAny {Alpha, Beta, Example, Federation, IPv6DualStack, LoadBalancer, Networking-IPv6, PerformanceDNS, SCTPConnectivity, KubeProxyDaemonSetMigration}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pohly you went through this before, can you help us with the review?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quoting of "--test-args" content is insane. It is totally non-obvious how that string gets passed on and who breaks it into individual parameters (--ginkgo.skip, --ginkgo.label-filter, etc.).

For node tests, I gave up in #32776 and just used the one variant that seemed to work, which was single quotes in YAML and double quotes inside the string.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are using YAML - > quoting here, so you don't need the outer quotes. Perhaps --ginkgo.label-filter="..." works if single quotes didn't.

I doubt that leaving them out entirely works.

- --timeout=100m
image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20240903-6a352c5344-master
resources:
Expand Down